X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fmouse.c;h=81eccfb8385b5bf9146c9eca42da2adc044be0b3;hb=4c672be2e1f39e72eb7d7e99f129e61338f481b2;hp=8456079d7a1c020ca6f817edb94d924c6a68f795;hpb=740c5b2a20d5110435d0874f8cc6a4c9dfd14777;p=chaz%2Fopenbox diff --git a/openbox/mouse.c b/openbox/mouse.c index 8456079d..81eccfb8 100644 --- a/openbox/mouse.c +++ b/openbox/mouse.c @@ -1,6 +1,7 @@ /* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*- mouse.c for the Openbox window manager + Copyright (c) 2006 Mikael Magnusson Copyright (c) 2003 Ben Jansens This program is free software; you can redistribute it and/or modify @@ -93,7 +94,7 @@ void mouse_grab_for_client(ObClient *client, gboolean grab) GSList *it; for (i = 0; i < OB_FRAME_NUM_CONTEXTS; ++i) - for (it = bound_contexts[i]; it != NULL; it = g_slist_next(it)) { + for (it = bound_contexts[i]; it; it = g_slist_next(it)) { /* grab/ungrab the button */ ObMouseBinding *b = it->data; Window win; @@ -124,8 +125,8 @@ static void grab_all_clients(gboolean grab) { GList *it; - for (it = client_list; it != NULL; it = it->next) - mouse_grab_for_client(it->data, grab); + for (it = client_list; it; it = g_list_next(it)) + mouse_grab_for_client(it->data, grab); } void mouse_unbind_all() @@ -134,14 +135,14 @@ void mouse_unbind_all() GSList *it; for(i = 0; i < OB_FRAME_NUM_CONTEXTS; ++i) { - for (it = bound_contexts[i]; it != NULL; it = it->next) { + for (it = bound_contexts[i]; it; it = g_slist_next(it)) { ObMouseBinding *b = it->data; gint j; for (j = 0; j < OB_NUM_MOUSE_ACTIONS; ++j) { GSList *it; - for (it = b->actions[j]; it; it = it->next) + for (it = b->actions[j]; it; it = g_slist_next(it)) action_unref(it->data); g_slist_free(b->actions[j]); } @@ -154,12 +155,12 @@ void mouse_unbind_all() static gboolean fire_binding(ObMouseAction a, ObFrameContext context, ObClient *c, guint state, - guint button, gint x, gint y) + guint button, gint x, gint y, Time time) { GSList *it; ObMouseBinding *b; - for (it = bound_contexts[context]; it != NULL; it = it->next) { + for (it = bound_contexts[context]; it; it = g_slist_next(it)) { b = it->data; if (b->state == state && b->button == button) break; @@ -167,7 +168,7 @@ static gboolean fire_binding(ObMouseAction a, ObFrameContext context, /* if not bound, then nothing to do! */ if (it == NULL) return FALSE; - action_run_mouse(b->actions[a], c, context, state, button, x, y); + action_run_mouse(b->actions[a], c, context, state, button, x, y, time); return TRUE; } @@ -195,11 +196,12 @@ void mouse_event(ObClient *client, XEvent *e) fire_binding(OB_MOUSE_ACTION_PRESS, context, client, e->xbutton.state, e->xbutton.button, - e->xbutton.x_root, e->xbutton.y_root); + e->xbutton.x_root, e->xbutton.y_root, + e->xbutton.time); if (CLIENT_CONTEXT(context, client)) { /* Replay the event, so it goes to the client*/ - XAllowEvents(ob_display, ReplayPointer, event_lasttime); + XAllowEvents(ob_display, ReplayPointer, event_curtime); /* Fall through to the release case! */ } else break; @@ -248,19 +250,22 @@ void mouse_event(ObClient *client, XEvent *e) fire_binding(OB_MOUSE_ACTION_RELEASE, context, client, e->xbutton.state, e->xbutton.button, - e->xbutton.x_root, e->xbutton.y_root); + e->xbutton.x_root, e->xbutton.y_root, + e->xbutton.time); if (click) fire_binding(OB_MOUSE_ACTION_CLICK, context, client, e->xbutton.state, e->xbutton.button, e->xbutton.x_root, - e->xbutton.y_root); + e->xbutton.y_root, + e->xbutton.time); if (dclick) fire_binding(OB_MOUSE_ACTION_DOUBLE_CLICK, context, client, e->xbutton.state, e->xbutton.button, e->xbutton.x_root, - e->xbutton.y_root); + e->xbutton.y_root, + e->xbutton.time); break; case MotionNotify: @@ -283,7 +288,7 @@ void mouse_event(ObClient *client, XEvent *e) break; fire_binding(OB_MOUSE_ACTION_MOTION, context, - client, state, button, px, py); + client, state, button, px, py, e->xmotion.time); button = 0; state = 0; } @@ -314,12 +319,12 @@ gboolean mouse_bind(const gchar *buttonstr, const gchar *contextstr, return FALSE; } - for (it = bound_contexts[context]; it != NULL; it = it->next){ - b = it->data; - if (b->state == state && b->button == button) { + for (it = bound_contexts[context]; it; it = g_slist_next(it)) { + b = it->data; + if (b->state == state && b->button == button) { b->actions[mact] = g_slist_append(b->actions[mact], action); return TRUE; - } + } } /* when there are no modifiers in the binding, then the action cannot