X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fmenu.c;h=a4f62f6c7301f87778dbf571dc3e36556a96911f;hb=36a437a70291c94b4c591df0cd99345f052a3e0c;hp=fcf5d1689e904d71234f1fb43be0666420c999b0;hpb=0b3cfc9de550f3f922bfb3c41acb96bbb1e00b64;p=chaz%2Fopenbox diff --git a/openbox/menu.c b/openbox/menu.c index fcf5d168..a4f62f6c 100644 --- a/openbox/menu.c +++ b/openbox/menu.c @@ -49,6 +49,7 @@ static GHashTable *menu_hash = NULL; static ObtXmlInst *menu_parse_inst; static ObMenuParseState menu_parse_state; static gboolean menu_can_hide = FALSE; +static guint menu_timeout_id = 0; static void menu_destroy_hash_value(ObMenu *self); static void parse_menu_item(xmlNodePtr node, gpointer data); @@ -58,13 +59,6 @@ static gunichar parse_shortcut(const gchar *label, gboolean allow_shortcut, gchar **strippedlabel, guint *position, gboolean *always_show); -static void client_dest(ObClient *client, gpointer data) -{ - /* menus can be associated with a client, so close any that are since - we are disappearing now */ - menu_frame_hide_all_client(client); -} - void menu_startup(gboolean reconfig) { gboolean loaded = FALSE; @@ -114,16 +108,10 @@ void menu_startup(gboolean reconfig) } g_assert(menu_parse_state.parent == NULL); - - if (!reconfig) - client_add_destroy_notify(client_dest, NULL); } void menu_shutdown(gboolean reconfig) { - if (!reconfig) - client_remove_destroy_notify(client_dest); - obt_xml_instance_unref(menu_parse_inst); menu_parse_inst = NULL; @@ -218,6 +206,7 @@ static gunichar parse_shortcut(const gchar *label, gboolean allow_shortcut, *strippedlabel = NULL; } else { gchar *i; + gboolean escape; *strippedlabel = g_strdup(label); @@ -225,20 +214,33 @@ static gunichar parse_shortcut(const gchar *label, gboolean allow_shortcut, have to just use the first valid character */ - i = strchr(*strippedlabel, '_'); + /* allow __ to escape an underscore */ + i = *strippedlabel; + do { + escape = FALSE; + i = strchr(i, '_'); + if (i && *(i+1) == '_') { + gchar *j; + + /* remove the escape '_' from the string */ + for (j = i; *j != '\0'; ++j) + *j = *(j+1); + + ++i; + escape = TRUE; + } + } while (escape); + if (allow_shortcut && i != NULL) { /* there is an underscore in the string */ /* you have to use a printable ascii character for shortcuts don't allow space either, so you can have like "a _ b" */ - if (VALID_SHORTCUT(*(i+1)) || *(i+1) == '_') { - /* Allow you to escape the first _ by putting __ */ - if (*(i+1) != '_') { - shortcut = g_unichar_tolower(g_utf8_get_char(i+1)); - *position = i - *strippedlabel; - *always_show = TRUE; - } + if (VALID_SHORTCUT(*(i+1))) { + shortcut = g_unichar_tolower(g_utf8_get_char(i+1)); + *position = i - *strippedlabel; + *always_show = TRUE; /* remove the '_' from the string */ for (; *i != '\0'; ++i) @@ -269,20 +271,48 @@ static void parse_menu_item(xmlNodePtr node, gpointer data) { ObMenuParseState *state = data; gchar *label; + gchar *icon; + ObMenuEntry *e; if (state->parent) { + /* Don't try to extract "icon" attribute if icons in user-defined + menus are not enabled. */ + if (obt_xml_attr_string(node, "label", &label)) { + xmlNodePtr c; GSList *acts = NULL; - node = obt_xml_find_node(node->children, "action"); - while (node) { - ObActionsAct *action = actions_parse(node); + c = obt_xml_find_node(node->children, "action"); + while (c) { + ObActionsAct *action = actions_parse(c); if (action) acts = g_slist_append(acts, action); - node = obt_xml_find_node(node->next, "action"); + c = obt_xml_find_node(node->next, "action"); } + e = menu_add_normal(state->parent, -1, label, acts, TRUE); + + if (config_menu_show_icons && + obt_xml_attr_string(node, "icon", &icon)) + { + RrImage *ic; + + ic = RrImageCacheFindName(ob_rr_icons, icon); + if (ic) + RrImageRef(ic); + else { + ic = RrImageNew(ob_rr_icons); + if (!RrImageAddPictureName(ic, icon)) { + RrImageUnref(ic); /* no need to keep it around */ + ic = NULL; + } + } + e->data.normal.icon = ic; + + if (e->data.normal.icon) + e->data.normal.icon_alpha = 0xff; - menu_add_normal(state->parent, -1, label, acts, TRUE); + g_free(icon); + } g_free(label); } } @@ -345,7 +375,7 @@ ObMenu* menu_new(const gchar *name, const gchar *title, { ObMenu *self; - self = g_new0(ObMenu, 1); + self = g_slice_new0(ObMenu); self->name = g_strdup(name); self->data = data; @@ -364,7 +394,7 @@ ObMenu* menu_new(const gchar *name, const gchar *title, more_menu->more_menu will always be NULL, since there is only 1 for each menu. */ - self->more_menu = g_new0(ObMenu, 1); + self->more_menu = g_slice_new0(ObMenu); self->more_menu->name = _("More..."); self->more_menu->title = _("More..."); self->more_menu->data = data; @@ -394,9 +424,9 @@ static void menu_destroy_hash_value(ObMenu *self) g_free(self->name); g_free(self->title); g_free(self->execute); - g_free(self->more_menu); + g_slice_free(ObMenu, self->more_menu); - g_free(self); + g_slice_free(ObMenu, self); } void menu_free(ObMenu *menu) @@ -408,6 +438,7 @@ void menu_free(ObMenu *menu) static gboolean menu_hide_delay_func(gpointer data) { menu_can_hide = TRUE; + menu_timeout_id = 0; return FALSE; /* no repeat */ } @@ -457,10 +488,11 @@ void menu_show(gchar *name, gint x, gint y, gboolean mouse, ObClient *client) menu_can_hide = TRUE; else { menu_can_hide = FALSE; - obt_main_loop_timeout_add(ob_main_loop, - config_menu_hide_delay * 1000, - menu_hide_delay_func, - NULL, g_direct_equal, NULL); + if (menu_timeout_id) g_source_remove(menu_timeout_id); + menu_timeout_id = g_timeout_add_full(G_PRIORITY_DEFAULT, + config_menu_hide_delay, + menu_hide_delay_func, + NULL, NULL); } } } @@ -476,7 +508,7 @@ static ObMenuEntry* menu_entry_new(ObMenu *menu, ObMenuEntryType type, gint id) g_assert(menu); - self = g_new0(ObMenuEntry, 1); + self = g_slice_new0(ObMenuEntry); self->ref = 1; self->type = type; self->menu = menu; @@ -521,7 +553,7 @@ void menu_entry_unref(ObMenuEntry *self) break; } - g_free(self); + g_slice_free(ObMenuEntry, self); } } @@ -625,6 +657,11 @@ void menu_set_execute_func(ObMenu *self, ObMenuExecuteFunc func) self->more_menu->execute_func = func; /* keep it in sync */ } +void menu_set_cleanup_func(ObMenu *self, ObMenuCleanupFunc func) +{ + self->cleanup_func = func; +} + void menu_set_destroy_func(ObMenu *self, ObMenuDestroyFunc func) { self->destroy_func = func;