X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fkeyboard.c;h=c318a4cf14b0f0b31dbf5ed8f5c638811c80d191;hb=c38a756ae50616b1431e3137141189a5588654a0;hp=2c60ac3d4f632e14c195eb0c1ce0380483b94263;hpb=e8dbe09cddf15de9b48539cac4f1f6639962a6d7;p=chaz%2Fopenbox diff --git a/openbox/keyboard.c b/openbox/keyboard.c index 2c60ac3d..c318a4cf 100644 --- a/openbox/keyboard.c +++ b/openbox/keyboard.c @@ -25,7 +25,7 @@ #include "event.h" #include "grab.h" #include "client.h" -#include "action.h" +#include "actions.h" #include "prop.h" #include "menuframe.h" #include "config.h" @@ -38,16 +38,8 @@ #include -typedef struct { - gboolean active; - guint state; - ObClient *client; - ObAction *action; -} ObInteractiveState; - KeyBindingTree *keyboard_firstnode = NULL; static ObPopup *popup = NULL; -static ObInteractiveState istate; static KeyBindingTree *curpos; static void grab_keys(gboolean grab) @@ -59,14 +51,15 @@ static void grab_keys(gboolean grab) if (grab) { p = curpos ? curpos->first_child : keyboard_firstnode; while (p) { - grab_key(p->key, p->state, RootWindow(ob_display, ob_screen), - GrabModeAsync); + if (p->key) + grab_key(p->key, p->state, RootWindow(ob_display, ob_screen), + GrabModeSync); p = p->next_sibling; } if (curpos) grab_key(config_keyboard_reset_keycode, config_keyboard_reset_state, - RootWindow(ob_display, ob_screen), GrabModeAsync); + RootWindow(ob_display, ob_screen), GrabModeSync); } } @@ -87,6 +80,7 @@ static void set_curpos(KeyBindingTree *newpos) if (curpos != NULL) { gchar *text = NULL; GList *it; + Rect *a; for (it = curpos->keylist; it; it = g_list_next(it)) { gchar *oldtext = text; @@ -97,10 +91,12 @@ static void set_curpos(KeyBindingTree *newpos) g_free(oldtext); } - popup_position(popup, NorthWestGravity, 10, 10); + a = screen_physical_area_active(); + popup_position(popup, NorthWestGravity, a->x + 10, a->y + 10); /* 1 second delay for the popup to show */ popup_delay_show(popup, G_USEC_PER_SEC, text); g_free(text); + g_free(a); } else { popup_hide(popup); } @@ -120,7 +116,7 @@ void keyboard_reset_chains(gint break_chroots) set_curpos(p); } -void keyboard_unbind_all() +void keyboard_unbind_all(void) { tree_destroy(keyboard_firstnode); keyboard_firstnode = NULL; @@ -139,11 +135,10 @@ void keyboard_chroot(GList *keylist) } } -gboolean keyboard_bind(GList *keylist, ObAction *action) +gboolean keyboard_bind(GList *keylist, ObActionsAct *action) { KeyBindingTree *tree, *t; gboolean conflict; - gboolean mods = TRUE; g_assert(keylist != NULL); g_assert(action != NULL); @@ -164,20 +159,8 @@ gboolean keyboard_bind(GList *keylist, ObAction *action) return FALSE; } - /* find if every key in this chain has modifiers, and also find the - bottom node of the tree */ - while (t->first_child) { - if (!t->state) - mods = FALSE; - t = t->first_child; - } - - /* when there are no modifiers in the binding, then the action cannot - be interactive */ - if (!mods && action->data.any.interactive) { - action->data.any.interactive = FALSE; - action->data.inter.final = TRUE; - } + /* find the bottom node */ + for (; t->first_child; t = t->first_child); /* set the action */ t->actions = g_slist_append(t->actions, action); @@ -188,58 +171,7 @@ gboolean keyboard_bind(GList *keylist, ObAction *action) return TRUE; } -static void keyboard_interactive_end(guint state, gboolean cancel, Time time, - gboolean ungrab) -{ - GSList *alist; - - g_assert(istate.active); - - /* ungrab first so they won't be NotifyWhileGrabbed */ - if (ungrab) - ungrab_keyboard(); - - /* set this before running the actions so they know the keyboard is not - grabbed */ - istate.active = FALSE; - - alist = g_slist_append(NULL, istate.action); - action_run_interactive(alist, istate.client, state, time, cancel, TRUE); - g_slist_free(alist); -} - -static void keyboard_interactive_end_client(ObClient *client, gpointer data) -{ - if (istate.active && istate.client == client) - istate.client = NULL; -} - - -void keyboard_interactive_cancel() -{ - keyboard_interactive_end(0, TRUE, event_curtime, TRUE); -} - -gboolean keyboard_interactive_grab(guint state, ObClient *client, - ObAction *action) -{ - g_assert(action->data.any.interactive); - - if (!istate.active) { - if (!grab_keyboard()) - return FALSE; - } else if (action->func != istate.action->func) { - keyboard_interactive_end(state, TRUE, action->data.any.time, FALSE); - } - - istate.active = TRUE; - istate.state = state; - istate.client = client; - istate.action = action; - - return TRUE; -} - +#if 0 gboolean keyboard_process_interactive_grab(const XEvent *e, ObClient **client) { gboolean handled = FALSE; @@ -272,12 +204,19 @@ gboolean keyboard_process_interactive_grab(const XEvent *e, ObClient **client) return handled; } +#endif void keyboard_event(ObClient *client, const XEvent *e) { KeyBindingTree *p; + if (e->type == KeyRelease) { + grab_key_passive_count(-1); + return; + } + g_assert(e->type == KeyPress); + grab_key_passive_count(1); if (e->xkey.keycode == config_keyboard_reset_keycode && e->xkey.state == config_keyboard_reset_state) @@ -309,48 +248,76 @@ void keyboard_event(ObClient *client, const XEvent *e) } else if (p->chroot) /* an empty chroot */ set_curpos(p); else { - keyboard_reset_chains(0); - - /* If we don't have the keyboard grabbed, then ungrab it with - XUngrabKeyboard, so that there is not a passive grab left - on from the KeyPress. If the grab is left on, and focus - moves during that time, it will be NotifyWhileGrabbed, and - applications like to ignore those! */ - if (!keyboard_interactively_grabbed()) - XUngrabKeyboard(ob_display, e->xkey.time); - - action_run_key(p->actions, client, e->xkey.state, - e->xkey.x_root, e->xkey.y_root, - e->xkey.time); + GSList *it; + + for (it = p->actions; it; it = g_slist_next(it)) + if (actions_act_is_interactive(it->data)) break; + if (it == NULL) /* reset if the actions are not interactive */ + keyboard_reset_chains(0); + + actions_run_acts(p->actions, OB_USER_ACTION_KEYBOARD_KEY, + e->xkey.state, e->xkey.x_root, e->xkey.y_root, + 0, OB_FRAME_CONTEXT_NONE, client); } break; } p = p->next_sibling; } + + XAllowEvents(ob_display, AsyncKeyboard, event_curtime); +} + +static void node_rebind(KeyBindingTree *node) +{ + if (node->first_child) { + /* find leaf nodes */ + node_rebind(node->first_child); + + /* for internal nodes, add them to the tree if they + are a chroot, but do this after adding their + children */ + if (node->chroot) + keyboard_chroot(node->keylist); + } + else { + /* for leaf nodes, rebind each action assigned to it */ + while (node->actions) { + /* add each action, and remove them from the original tree so + they don't get free'd on us */ + keyboard_bind(node->keylist, node->actions->data); + node->actions = g_slist_delete_link(node->actions, node->actions); + } + + if (node->chroot) + keyboard_chroot(node->keylist); + } + + /* go through each sibling */ + if (node->next_sibling) node_rebind(node->next_sibling); } -gboolean keyboard_interactively_grabbed() +void keyboard_rebind(void) { - return istate.active; + KeyBindingTree *old; + + old = keyboard_firstnode; + keyboard_firstnode = NULL; + node_rebind(old); + + tree_destroy(old); + set_curpos(NULL); + grab_keys(TRUE); } void keyboard_startup(gboolean reconfig) { grab_keys(TRUE); - popup = popup_new(FALSE); - - if (!reconfig) - client_add_destroy_notify(keyboard_interactive_end_client, NULL); + popup = popup_new(); + popup_set_text_align(popup, RR_JUSTIFY_CENTER); } void keyboard_shutdown(gboolean reconfig) { - if (!reconfig) - client_remove_destroy_notify(keyboard_interactive_end_client); - - if (istate.active) - keyboard_interactive_cancel(); - ob_main_loop_timeout_remove(ob_main_loop, chain_timeout); keyboard_unbind_all();