X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Ffocus.c;h=fad53e92dcf67897f927076129ce3f2465f44ad6;hb=7d164842e0d0c3138401fad0dafc6f21bba0a04f;hp=42241224534e35fc07f021b0c4f86d4d0d1705c3;hpb=eb09b1873d731a0e7290334a832a76cb233f34a7;p=chaz%2Fopenbox diff --git a/openbox/focus.c b/openbox/focus.c index 42241224..fad53e92 100644 --- a/openbox/focus.c +++ b/openbox/focus.c @@ -94,11 +94,10 @@ void focus_set_client(ObClient *client) } } -static ObClient* focus_fallback_target(gboolean allow_refocus) +static ObClient* focus_fallback_target(gboolean allow_refocus, ObClient *old) { GList *it; ObClient *c; - ObClient *old = focus_client; ob_debug_type(OB_DEBUG_FOCUS, "trying pointer stuff\n"); if (config_focus_follow && !config_focus_last) @@ -111,17 +110,6 @@ static ObClient* focus_fallback_target(gboolean allow_refocus) return c; } - ob_debug_type(OB_DEBUG_FOCUS, "trying omnipresentness\n"); - if (allow_refocus && old && - old->desktop == DESKTOP_ALL && - client_normal(old) && - client_focus(old)) - { - ob_debug_type(OB_DEBUG_FOCUS, "found in omnipresentness\n"); - return old; - } - - ob_debug_type(OB_DEBUG_FOCUS, "trying the focus order\n"); for (it = focus_order; it; it = g_list_next(it)) { c = it->data; @@ -167,13 +155,14 @@ static ObClient* focus_fallback_target(gboolean allow_refocus) ObClient* focus_fallback(gboolean allow_refocus) { ObClient *new; + ObClient *old = focus_client; /* unfocus any focused clients.. they can be focused by Pointer events and such, and then when we try focus them, we won't get a FocusIn event at all for them. */ focus_nothing(); - new = focus_fallback_target(allow_refocus); + new = focus_fallback_target(allow_refocus, old); return new; } @@ -186,12 +175,8 @@ void focus_nothing() screen_install_colormap(NULL, TRUE); } - /* Don't set focus_client to NULL here. It will be set to NULL when the - FocusOut event comes. Otherwise, if we focus nothing and then focus the - same window again, The focus code says nothing changed, but focus_client - ends up being NULL anyways. - focus_client = NULL; - */ + /* nothing is focused, update the colormap and _the root property_ */ + focus_set_client(NULL); /* if there is a grab going on, then we need to cancel it. if we move focus during the grab, applications will get NotifyWhileGrabbed events