X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Ffocus.c;h=f947fe33fd5f8e587acfdbd8a4eac890dc15bcb6;hb=65a176330a07cfc965b0e5cd98e014aba4e1672c;hp=5d9e0fe4a294078ceed942bdc7bcddc207dc7278;hpb=82b2f0aa7a1723632e8d3cf7dc772e4bdb66868a;p=chaz%2Fopenbox diff --git a/openbox/focus.c b/openbox/focus.c index 5d9e0fe4..f947fe33 100644 --- a/openbox/focus.c +++ b/openbox/focus.c @@ -37,12 +37,20 @@ #include #include -#define FOCUS_INDICATOR_WIDTH 5 +#define FOCUS_INDICATOR_WIDTH 6 ObClient *focus_client = NULL; GList *focus_order = NULL; ObClient *focus_cycle_target = NULL; +/*! This variable is used for focus fallback. If we fallback to a window, we + set this to the window. And when focus goes somewhere after that, it will + be set to NULL. If between falling back to that window and something + getting focused, the window gets unmanaged, then if there are no incoming + FocusIn events, we fallback again because focus has just gotten itself lost. + */ +static ObClient *focus_tried = NULL; + struct { InternalWindow top; InternalWindow left; @@ -57,8 +65,10 @@ static ObIconPopup *focus_cycle_popup; static gboolean valid_focus_target(ObClient *ft, gboolean all_desktops, - gboolean dock_windows); -static void focus_cycle_destructor(ObClient *client, gpointer data); + gboolean dock_windows, + gboolean desktop_windows); +static void focus_cycle_destroy_notify(ObClient *client, gpointer data); +static void focus_tried_hide_notify(ObClient *client, gpointer data); static Window createWindow(Window parent, gulong mask, XSetWindowAttributes *attrib) @@ -76,7 +86,9 @@ void focus_startup(gboolean reconfig) if (!reconfig) { XSetWindowAttributes attr; - client_add_destructor(focus_cycle_destructor, NULL); + client_add_destroy_notify(focus_cycle_destroy_notify, NULL); + client_add_destroy_notify(focus_tried_hide_notify, NULL); + client_add_hide_notify(focus_tried_hide_notify, NULL); /* start with nothing focused */ focus_nothing(); @@ -129,7 +141,9 @@ void focus_shutdown(gboolean reconfig) icon_popup_free(focus_cycle_popup); if (!reconfig) { - client_remove_destructor(focus_cycle_destructor); + client_remove_destroy_notify(focus_cycle_destroy_notify); + client_remove_destroy_notify(focus_tried_hide_notify); + client_remove_hide_notify(focus_tried_hide_notify); /* reset focus to root */ XSetInputFocus(ob_display, PointerRoot, RevertToNone, CurrentTime); @@ -166,7 +180,7 @@ void focus_set_client(ObClient *client) be used. */ if (focus_cycle_target) - focus_cycle(TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE); + focus_cycle(TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE); focus_client = client; @@ -183,9 +197,12 @@ void focus_set_client(ObClient *client) PROP_SET32(RootWindow(ob_display, ob_screen), net_active_window, window, active); } + + + focus_tried = NULL; /* focus isn't "trying" to go anywhere now */ } -ObClient* focus_fallback_target(gboolean allow_refocus, ObClient *old) +static ObClient* focus_fallback_target(gboolean allow_refocus, ObClient *old) { GList *it; ObClient *target = NULL; @@ -224,7 +241,7 @@ ObClient* focus_fallback_target(gboolean allow_refocus, ObClient *old) } - ob_debug_type(OB_DEBUG_FOCUS, "trying the focus order\n"); + ob_debug_type(OB_DEBUG_FOCUS, "trying the focus order\n"); for (it = focus_order; it; it = g_list_next(it)) if (allow_refocus || it->data != old) { ObClient *c = it->data; @@ -255,19 +272,26 @@ ObClient* focus_fallback_target(gboolean allow_refocus, ObClient *old) return desktop; } -void focus_fallback(gboolean allow_refocus) +ObClient* focus_fallback(gboolean allow_refocus) { ObClient *new; - ObClient *old = focus_client; + ObClient *old; + + old = focus_client; + new = focus_fallback_target(allow_refocus, focus_client); /* unfocus any focused clients.. they can be focused by Pointer events - and such, and then when I try focus them, I won't get a FocusIn event - at all for them. - */ + and such, and then when we try focus them, we won't get a FocusIn + event at all for them. */ focus_nothing(); - if ((new = focus_fallback_target(allow_refocus, old))) + if (new) { client_focus(new); + /* remember that we tried to send focus here */ + focus_tried = new; + } + + return new; } void focus_nothing() @@ -278,7 +302,24 @@ void focus_nothing() screen_install_colormap(NULL, TRUE); } + /* Don't set focus_client to NULL here. It will be set to NULL when the + FocusOut event comes. Otherwise, if we focus nothing and then focus the + same window again, The focus code says nothing changed, but focus_client + ends up being NULL anyways. focus_client = NULL; + */ + + focus_tried = NULL; /* focus isn't "trying" to go anywhere now */ + + /* if there is a grab going on, then we need to cancel it. if we move + focus during the grab, applications will get NotifyWhileGrabbed events + and ignore them ! + + actions should not rely on being able to move focus during an + interactive grab. + */ + if (keyboard_interactively_grabbed()) + keyboard_interactive_cancel(); /* when nothing will be focused, send focus to the backup target */ XSetInputFocus(ob_display, screen_support_win, RevertToPointerRoot, @@ -295,7 +336,6 @@ static gchar *popup_get_name(ObClient *c, ObClient **nametarget) /* find our highest direct parent, including non-normal windows */ for (p = c; p->transient_for && p->transient_for != OB_TRAN_GROUP; p = p->transient_for); - if (nametarget) *nametarget = p; if (c->desktop != DESKTOP_ALL && c->desktop != screen_desktop) desk = screen_desktop_names[c->desktop]; @@ -315,11 +355,14 @@ static gchar *popup_get_name(ObClient *c, ObClient **nametarget) } g_free(title); + /* set this only if we're returning true and they asked for it */ + if (ret && nametarget) *nametarget = p; return ret; } static void popup_cycle(ObClient *c, gboolean show, - gboolean all_desktops, gboolean dock_windows) + gboolean all_desktops, gboolean dock_windows, + gboolean desktop_windows) { gchar *showtext = NULL; ObClient *showtarget; @@ -353,7 +396,9 @@ static void popup_cycle(ObClient *c, gboolean show, /* build a list of all the valid focus targets */ for (it = focus_order; it; it = g_list_next(it)) { ObClient *ft = it->data; - if (valid_focus_target(ft, all_desktops, dock_windows)) { + if (valid_focus_target(ft, all_desktops, dock_windows + , desktop_windows)) + { targets = g_list_prepend(targets, ft); ++n; } @@ -361,13 +406,15 @@ static void popup_cycle(ObClient *c, gboolean show, /* make it null terminated so we can use g_strfreev */ names = g_new(char*, n+1); for (it = targets, i = 0; it; it = g_list_next(it), ++i) { - ObClient *ft = it->data; - names[i] = popup_get_name(ft, &showtarget); + ObClient *ft = it->data, *t; + names[i] = popup_get_name(ft, &t); - /* little optimization.. save this text so we dont have to get it - again */ - if (ft == c) + /* little optimization.. save this text and client, so we dont + have to get it again */ + if (ft == c) { showtext = g_strdup(names[i]); + showtarget = t; + } } names[n] = NULL; @@ -382,13 +429,13 @@ static void popup_cycle(ObClient *c, gboolean show, g_free(showtext); } -static void focus_cycle_destructor(ObClient *client, gpointer data) +static void focus_cycle_destroy_notify(ObClient *client, gpointer data) { /* end cycling if the target disappears. CurrentTime is fine, time won't be used */ if (focus_cycle_target == client) - focus_cycle(TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE); + focus_cycle(TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE, TRUE); } void focus_cycle_draw_indicator() @@ -525,9 +572,32 @@ void focus_cycle_draw_indicator() } } +static gboolean has_valid_group_siblings_on_desktop(ObClient *ft, + gboolean all_desktops) + +{ + GSList *it; + + if (!ft->group) return FALSE; + + for (it = ft->group->members; it; it = g_slist_next(it)) { + ObClient *c = it->data; + /* check that it's not a helper window to avoid infinite recursion */ + if (c != ft && !client_helper(c) && + valid_focus_target(c, all_desktops, FALSE, FALSE)) + { + return TRUE; + } + } + return FALSE; +} + +/*! @param allow_helpers This is used for calling itself recursively while + checking helper windows. */ static gboolean valid_focus_target(ObClient *ft, gboolean all_desktops, - gboolean dock_windows) + gboolean dock_windows, + gboolean desktop_windows) { gboolean ok = FALSE; @@ -542,27 +612,29 @@ static gboolean valid_focus_target(ObClient *ft, ok = ok && (ft->can_focus || ft->focus_notify); /* it's the right type of window */ - if (dock_windows) - ok = ok && ft->type == OB_CLIENT_TYPE_DOCK; + if (dock_windows || desktop_windows) + ok = ok && ((dock_windows && ft->type == OB_CLIENT_TYPE_DOCK) || + (desktop_windows && ft->type == OB_CLIENT_TYPE_DESKTOP)); else - ok = ok && (ft->type == OB_CLIENT_TYPE_NORMAL || - ft->type == OB_CLIENT_TYPE_DIALOG || - ((ft->type == OB_CLIENT_TYPE_TOOLBAR || - ft->type == OB_CLIENT_TYPE_MENU || - ft->type == OB_CLIENT_TYPE_UTILITY) && - /* let alt-tab go to these windows when a window in its - group already has focus ... */ - ((focus_client && ft->group == focus_client->group) || - /* ... or if there are no application windows in its - group */ - !client_has_application_group_siblings(ft)))); + /* normal non-helper windows are valid targets */ + ok = ok && + ((client_normal(ft) && !client_helper(ft)) + || + /* helper windows are valid targets it... */ + (client_helper(ft) && + /* ...a window in its group already has focus ... */ + ((focus_client && ft->group == focus_client->group) || + /* ... or if there are no other windows in its group + that can be cycled to instead */ + !has_valid_group_siblings_on_desktop(ft, all_desktops)))); /* it's not set to skip the taskbar (unless it is a type that would be expected to set this hint */ - ok = ok && (!(ft->type == OB_CLIENT_TYPE_DOCK || - ft->type == OB_CLIENT_TYPE_TOOLBAR || - ft->type == OB_CLIENT_TYPE_MENU || - ft->type == OB_CLIENT_TYPE_UTILITY) || + ok = ok && ((ft->type == OB_CLIENT_TYPE_DOCK || + ft->type == OB_CLIENT_TYPE_DESKTOP || + ft->type == OB_CLIENT_TYPE_TOOLBAR || + ft->type == OB_CLIENT_TYPE_MENU || + ft->type == OB_CLIENT_TYPE_UTILITY) || !ft->skip_taskbar); /* it's not going to just send fous off somewhere else (modal window) */ @@ -572,7 +644,7 @@ static gboolean valid_focus_target(ObClient *ft, } void focus_cycle(gboolean forward, gboolean all_desktops, - gboolean dock_windows, + gboolean dock_windows, gboolean desktop_windows, gboolean linear, gboolean interactive, gboolean dialog, gboolean done, gboolean cancel) { @@ -617,14 +689,17 @@ void focus_cycle(gboolean forward, gboolean all_desktops, if (it == NULL) it = g_list_last(list); } ft = it->data; - if (valid_focus_target(ft, all_desktops, dock_windows)) { + if (valid_focus_target(ft, all_desktops, dock_windows, + desktop_windows)) + { if (interactive) { if (ft != focus_cycle_target) { /* prevents flicker */ focus_cycle_target = ft; focus_cycle_draw_indicator(); } /* same arguments as valid_focus_target */ - popup_cycle(ft, dialog, all_desktops, dock_windows); + popup_cycle(ft, dialog, all_desktops, dock_windows, + desktop_windows); return; } else if (ft != focus_cycle_target) { focus_cycle_target = ft; @@ -646,7 +721,7 @@ done_cycle: if (interactive) { focus_cycle_draw_indicator(); - popup_cycle(ft, FALSE, FALSE, FALSE); + popup_cycle(ft, FALSE, FALSE, FALSE, FALSE); } return; @@ -654,7 +729,8 @@ done_cycle: /* this be mostly ripped from fvwm */ static ObClient *focus_find_directional(ObClient *c, ObDirection dir, - gboolean dock_windows) + gboolean dock_windows, + gboolean desktop_windows) { gint my_cx, my_cy, his_cx, his_cy; gint offset = 0; @@ -679,9 +755,13 @@ static ObClient *focus_find_directional(ObClient *c, ObDirection dir, /* the currently selected window isn't interesting */ if(cur == c) continue; - if (!dock_windows && !client_normal(cur)) + if (cur->type == OB_CLIENT_TYPE_DOCK && !dock_windows) continue; - if (dock_windows && cur->type != OB_CLIENT_TYPE_DOCK) + if (cur->type == OB_CLIENT_TYPE_DESKTOP && !desktop_windows) + continue; + if (!client_normal(cur) && + cur->type != OB_CLIENT_TYPE_DOCK && + cur->type != OB_CLIENT_TYPE_DESKTOP) continue; /* using c->desktop instead of screen_desktop doesn't work if the * current window was omnipresent, hope this doesn't have any other @@ -757,7 +837,7 @@ static ObClient *focus_find_directional(ObClient *c, ObDirection dir, } void focus_directional_cycle(ObDirection dir, gboolean dock_windows, - gboolean interactive, + gboolean desktop_windows, gboolean interactive, gboolean dialog, gboolean done, gboolean cancel) { static ObClient *first = NULL; @@ -779,12 +859,14 @@ void focus_directional_cycle(ObDirection dir, gboolean dock_windows, if (!focus_cycle_target) focus_cycle_target = focus_client; if (focus_cycle_target) - ft = focus_find_directional(focus_cycle_target, dir, dock_windows); + ft = focus_find_directional(focus_cycle_target, dir, dock_windows, + desktop_windows); else { GList *it; for (it = focus_order; it; it = g_list_next(it)) - if (valid_focus_target(it->data, FALSE, dock_windows)) + if (valid_focus_target(it->data, FALSE, dock_windows, + desktop_windows)) ft = it->data; } @@ -796,7 +878,8 @@ void focus_directional_cycle(ObDirection dir, gboolean dock_windows, } if (focus_cycle_target) { /* same arguments as valid_focus_target */ - popup_cycle(focus_cycle_target, dialog, FALSE, dock_windows); + popup_cycle(focus_cycle_target, dialog, FALSE, dock_windows, + desktop_windows); if (dialog) return; } @@ -810,7 +893,7 @@ done_cycle: focus_cycle_target = NULL; focus_cycle_draw_indicator(); - popup_cycle(ft, FALSE, FALSE, FALSE); + popup_cycle(ft, FALSE, FALSE, FALSE, FALSE); return; } @@ -875,3 +958,25 @@ ObClient *focus_order_find_first(guint desktop) } return NULL; } + +static void focus_tried_hide_notify(ObClient *client, gpointer data) +{ + XEvent ce; + + if (client == focus_tried) { + /* we were trying to focus this window but it's gone */ + + focus_tried = NULL; + + ob_debug_type(OB_DEBUG_FOCUS, "Tried to focus window 0x%x and it " + "is being unmanaged:\n"); + if (XCheckIfEvent(ob_display, &ce, event_look_for_focusin_client,NULL)) + { + XPutBackEvent(ob_display, &ce); + ob_debug_type(OB_DEBUG_FOCUS, " but another FocusIn is coming\n"); + } else { + ob_debug_type(OB_DEBUG_FOCUS, " so falling back focus again.\n"); + focus_fallback(TRUE); + } + } +}