X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Ffocus.c;h=ad7252b8db81668bf26629094f1c08f971e7d8b9;hb=c716d1788bb4f4b9db403617023f06347ba48102;hp=740ce07bda605eead2fef130a61a528570a10231;hpb=a3710c960115562bf436442d7e58feb887f744cb;p=chaz%2Fopenbox diff --git a/openbox/focus.c b/openbox/focus.c index 740ce07b..63eb2cca 100644 --- a/openbox/focus.c +++ b/openbox/focus.c @@ -1,7 +1,8 @@ /* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*- focus.c for the Openbox window manager - Copyright (c) 2003 Ben Jansens + Copyright (c) 2006 Mikael Magnusson + Copyright (c) 2003-2007 Dana Jansens This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -20,106 +21,80 @@ #include "event.h" #include "openbox.h" #include "grab.h" -#include "framerender.h" #include "client.h" #include "config.h" -#include "frame.h" -#include "screen.h" #include "group.h" +#include "focus_cycle.h" +#include "screen.h" #include "prop.h" +#include "keyboard.h" #include "focus.h" #include "stacking.h" -#include "popup.h" #include #include -#include -ObClient *focus_client; -GList **focus_order; /* these lists are created when screen_startup - sets the number of desktops */ -ObClient *focus_cycle_target; +#define FOCUS_INDICATOR_WIDTH 6 -static ObIconPopup *focus_cycle_popup; - -static void focus_cycle_destructor(ObClient *c) -{ - /* end cycling if the target disappears */ - if (focus_cycle_target == c) - focus_cycle(TRUE, TRUE, TRUE, TRUE, TRUE); -} +ObClient *focus_client = NULL; +GList *focus_order = NULL; void focus_startup(gboolean reconfig) { - focus_cycle_popup = icon_popup_new(TRUE); - - if (!reconfig) { - client_add_destructor((GDestroyNotify) focus_cycle_destructor); + if (reconfig) return; - /* start with nothing focused */ - focus_set_client(NULL); - } + /* start with nothing focused */ + focus_nothing(); } void focus_shutdown(gboolean reconfig) { - guint i; + if (reconfig) return; - icon_popup_free(focus_cycle_popup); - - if (!reconfig) { - client_remove_destructor((GDestroyNotify) focus_cycle_destructor); - - for (i = 0; i < screen_num_desktops; ++i) - g_list_free(focus_order[i]); - g_free(focus_order); - - /* reset focus to root */ - XSetInputFocus(ob_display, PointerRoot, RevertToPointerRoot, - event_lasttime); - } + /* reset focus to root */ + XSetInputFocus(ob_display, PointerRoot, RevertToNone, CurrentTime); } static void push_to_top(ObClient *client) { - guint desktop; + ObClient *p; + + /* if it is modal for a single window, then put that window at the top + of the focus order first, so it will be right after ours. the same is + done with stacking */ + if (client->modal && (p = client_direct_parent(client))) + push_to_top(p); - desktop = client->desktop; - if (desktop == DESKTOP_ALL) desktop = screen_desktop; - focus_order[desktop] = g_list_remove(focus_order[desktop], client); - focus_order[desktop] = g_list_prepend(focus_order[desktop], client); + focus_order = g_list_remove(focus_order, client); + focus_order = g_list_prepend(focus_order, client); } void focus_set_client(ObClient *client) { Window active; - ObClient *old; -#ifdef DEBUG_FOCUS - ob_debug("focus_set_client 0x%lx\n", client ? client->window : 0); -#endif + ob_debug_type(OB_DEBUG_FOCUS, + "focus_set_client 0x%lx\n", client ? client->window : 0); + + if (focus_client == client) + return; /* uninstall the old colormap, and install the new one */ screen_install_colormap(focus_client, FALSE); screen_install_colormap(client, TRUE); - if (client == NULL) { - /* when nothing will be focused, send focus to the backup target */ - XSetInputFocus(ob_display, screen_support_win, RevertToPointerRoot, - event_lasttime); - XSync(ob_display, FALSE); - } - /* in the middle of cycling..? kill it. */ - if (focus_cycle_target) - focus_cycle(TRUE, TRUE, TRUE, TRUE, TRUE); + focus_cycle_stop(focus_client); + focus_cycle_stop(client); - old = focus_client; focus_client = client; - /* move to the top of the list */ - if (client != NULL) + if (client != NULL) { + /* move to the top of the list */ push_to_top(client); + /* remove hiliting from the window when it gets focused */ + client_hilite(client, FALSE); + } /* set the NET_ACTIVE_WINDOW hint, but preserve it on shutdown */ if (ob_state() != OB_STATE_EXITING) { @@ -129,380 +104,258 @@ void focus_set_client(ObClient *client) } } -static gboolean focus_under_pointer() -{ - ObClient *c; - - if ((c = client_under_pointer())) - return client_normal(c) && client_focus(c); - return FALSE; -} - -/* finds the first transient that isn't 'skip' and ensure's that client_normal - is true for it */ -static ObClient *find_transient_recursive(ObClient *c, ObClient *top, ObClient *skip) -{ - GSList *it; - ObClient *ret; - - for (it = c->transients; it; it = it->next) { - if (it->data == top) return NULL; - ret = find_transient_recursive(it->data, top, skip); - if (ret && ret != skip && client_normal(ret)) return ret; - if (it->data != skip && client_normal(it->data)) return it->data; - } - return NULL; -} - -static gboolean focus_fallback_transient(ObClient *top, ObClient *old) -{ - ObClient *target = find_transient_recursive(top, top, old); - if (!target) { - /* make sure client_normal is true always */ - if (!client_normal(top)) - return FALSE; - target = top; /* no transient, keep the top */ - } - return client_focus(target); -} - -void focus_fallback(ObFocusFallbackType type) +static ObClient* focus_fallback_target(gboolean allow_refocus, + gboolean allow_pointer, + gboolean allow_omnipresent, + ObClient *old) { GList *it; - ObClient *old = NULL; - - old = focus_client; - - /* unfocus any focused clients.. they can be focused by Pointer events - and such, and then when I try focus them, I won't get a FocusIn event - at all for them. - */ - focus_set_client(NULL); + ObClient *c; - if (!config_focus_last && config_focus_follow) - if (focus_under_pointer()) - return; - - if (type == OB_FOCUS_FALLBACK_UNFOCUSING && old) { - /* try for transient relations */ - if (old->transient_for) { - if (old->transient_for == OB_TRAN_GROUP) { - for (it = focus_order[screen_desktop]; it; it = it->next) { - GSList *sit; - - for (sit = old->group->members; sit; sit = sit->next) - if (sit->data == it->data) - if (focus_fallback_transient(sit->data, old)) - return; - } - } else { - if (focus_fallback_transient(old->transient_for, old)) - return; - } + ob_debug_type(OB_DEBUG_FOCUS, "trying pointer stuff\n"); + if (allow_pointer && config_focus_follow) + if ((c = client_under_pointer()) && + (allow_refocus || client_focus_target(c) != old) && + (client_normal(c) && + client_focus(c))) + { + ob_debug_type(OB_DEBUG_FOCUS, "found in pointer stuff\n"); + return c; } -#if 0 - /* try for group relations */ - if (old->group) { - GSList *sit; - - for (it = focus_order[screen_desktop]; it != NULL; it = it->next) - for (sit = old->group->members; sit; sit = sit->next) - if (sit->data == it->data) - if (sit->data != old && client_normal(sit->data)) - if (client_can_focus(sit->data)) { - gboolean r = client_focus(sit->data); - assert(r); - return; - } + ob_debug_type(OB_DEBUG_FOCUS, "trying the focus order\n"); + for (it = focus_order; it; it = g_list_next(it)) { + c = it->data; + /* fallback focus to a window if: + 1. it is on the current desktop. this ignores omnipresent + windows, which are problematic in their own rite, unless they are + specifically allowed + 2. it is a valid auto-focus target + 3. it is not shaded + */ + if ((allow_omnipresent || c->desktop == screen_desktop) && + focus_valid_target(c, TRUE, FALSE, FALSE, FALSE, FALSE) && + !c->shaded && + (allow_refocus || client_focus_target(c) != old) && + client_focus(c)) + { + ob_debug_type(OB_DEBUG_FOCUS, "found in focus order\n"); + return c; } -#endif } - for (it = focus_order[screen_desktop]; it != NULL; it = it->next) - if (type != OB_FOCUS_FALLBACK_UNFOCUSING || it->data != old) - if (client_normal(it->data) && - /* dont fall back to 'anonymous' fullscreen windows. theres no - checks for this is in transient/group fallbacks, so they can - be fallback targets there. */ - !((ObClient*)it->data)->fullscreen && - client_can_focus(it->data)) { - gboolean r = client_focus(it->data); - assert(r); - return; - } - - /* nothing to focus, and already set it to none above */ -} - -static void popup_cycle(ObClient *c, gboolean show) -{ - if (!show) { - icon_popup_hide(focus_cycle_popup); - } else { - Rect *a; - ObClient *p = c; - char *title; - - a = screen_physical_area_monitor(0); - icon_popup_position(focus_cycle_popup, CenterGravity, - a->x + a->width / 2, a->y + a->height / 2); -/* icon_popup_size(focus_cycle_popup, a->height/2, a->height/16); - icon_popup_show(focus_cycle_popup, c->title, - client_icon(c, a->height/16, a->height/16)); -*/ - /* XXX the size and the font extents need to be related on some level - */ - icon_popup_size(focus_cycle_popup, POPUP_WIDTH, POPUP_HEIGHT); - - /* use the transient's parent's title/icon */ - while (p->transient_for && p->transient_for != OB_TRAN_GROUP) - p = p->transient_for; - - if (p == c) - title = NULL; - else - title = g_strconcat((c->iconic ? c->icon_title : c->title), - " - ", - (p->iconic ? p->icon_title : p->title), - NULL); - - icon_popup_show(focus_cycle_popup, - (title ? title : - (c->iconic ? c->icon_title : c->title)), - client_icon(p, 48, 48)); - g_free(title); + ob_debug_type(OB_DEBUG_FOCUS, "trying a desktop window\n"); + for (it = focus_order; it; it = g_list_next(it)) { + c = it->data; + /* fallback focus to a window if: + 1. it is on the current desktop. this ignores omnipresent + windows, which are problematic in their own rite. + 2. it is a normal type window, don't fall back onto a dock or + a splashscreen or a desktop window (save the desktop as a + backup fallback though) + */ + if (focus_valid_target(c, TRUE, FALSE, FALSE, FALSE, TRUE) && + (allow_refocus || client_focus_target(c) != old) && + client_focus(c)) + { + ob_debug_type(OB_DEBUG_FOCUS, "found a desktop window\n"); + return c; + } } -} -static gboolean valid_focus_target(ObClient *ft) -{ - /* we don't use client_can_focus here, because that doesn't let you - focus an iconic window, but we want to be able to, so we just check - if the focus flags on the window allow it, and its on the current - desktop */ - return (ft->transients == NULL && client_normal(ft) && - ((ft->can_focus || ft->focus_notify) && - !ft->skip_taskbar && - (ft->desktop == screen_desktop || ft->desktop == DESKTOP_ALL))); + return NULL; } -void focus_cycle(gboolean forward, gboolean linear, - gboolean dialog, gboolean done, gboolean cancel) +ObClient* focus_fallback(gboolean allow_refocus, gboolean allow_pointer, + gboolean allow_omnipresent, gboolean focus_lost) { - static ObClient *first = NULL; - static ObClient *t = NULL; - static GList *order = NULL; - GList *it, *start, *list; - ObClient *ft = NULL; - - if (cancel) { - if (focus_cycle_target) - frame_adjust_focus(focus_cycle_target->frame, FALSE); - if (focus_client) - frame_adjust_focus(focus_client->frame, TRUE); - focus_cycle_target = NULL; - goto done_cycle; - } else if (done && dialog) { - goto done_cycle; - } - - if (!focus_order[screen_desktop]) - goto done_cycle; + ObClient *new; + ObClient *old = focus_client; - if (!first) first = focus_client; - if (!focus_cycle_target) focus_cycle_target = focus_client; - - if (linear) list = client_list; - else list = focus_order[screen_desktop]; - - start = it = g_list_find(list, focus_cycle_target); - if (!start) /* switched desktops or something? */ - start = it = forward ? g_list_last(list) : g_list_first(list); - if (!start) goto done_cycle; - - do { - if (forward) { - it = it->next; - if (it == NULL) it = g_list_first(list); - } else { - it = it->prev; - if (it == NULL) it = g_list_last(list); - } - /*ft = client_focus_target(it->data);*/ - ft = it->data; - if (valid_focus_target(ft)) { - if (ft != focus_cycle_target) { /* prevents flicker */ - if (focus_cycle_target) - frame_adjust_focus(focus_cycle_target->frame, FALSE); - focus_cycle_target = ft; - frame_adjust_focus(focus_cycle_target->frame, TRUE); - } - popup_cycle(ft, dialog); - return; - } - } while (it != start); - -done_cycle: - if (done && focus_cycle_target) - client_activate(focus_cycle_target, FALSE); - - t = NULL; - first = NULL; - focus_cycle_target = NULL; - g_list_free(order); - order = NULL; + /* unfocus any focused clients.. they can be focused by Pointer events + and such, and then when we try focus them, we won't get a FocusIn + event at all for them. */ + if (focus_lost) + focus_nothing(); - popup_cycle(ft, FALSE); + new = focus_fallback_target(allow_refocus, allow_pointer, + allow_omnipresent, old); + /* get what was really focused */ + if (new) new = client_focus_target(new); - return; + return new; } -void focus_directional_cycle(ObDirection dir, - gboolean dialog, gboolean done, gboolean cancel) +void focus_nothing(void) { - static ObClient *first = NULL; - ObClient *ft = NULL; - - if (cancel) { - if (focus_cycle_target) - frame_adjust_focus(focus_cycle_target->frame, FALSE); - if (focus_client) - frame_adjust_focus(focus_client->frame, TRUE); - focus_cycle_target = NULL; - goto done_cycle; - } else if (done && dialog) { - goto done_cycle; - } - - if (!focus_order[screen_desktop]) - goto done_cycle; - - if (!first) first = focus_client; - if (!focus_cycle_target) focus_cycle_target = focus_client; - - if (focus_cycle_target) - ft = client_find_directional(focus_cycle_target, dir); - else { - GList *it; - - for (it = focus_order[screen_desktop]; it; it = g_list_next(it)) - if (valid_focus_target(it->data)) - ft = it->data; - } - - if (ft) { - if (ft != focus_cycle_target) {/* prevents flicker */ - if (focus_cycle_target) - frame_adjust_focus(focus_cycle_target->frame, FALSE); - focus_cycle_target = ft; - frame_adjust_focus(focus_cycle_target->frame, TRUE); - } + /* Install our own colormap */ + if (focus_client != NULL) { + screen_install_colormap(focus_client, FALSE); + screen_install_colormap(NULL, TRUE); } - if (focus_cycle_target) { - popup_cycle(focus_cycle_target, dialog); - if (dialog) - return; - } - - -done_cycle: - if (done && focus_cycle_target) - client_activate(focus_cycle_target, FALSE); - first = NULL; - focus_cycle_target = NULL; + /* nothing is focused, update the colormap and _the root property_ */ + focus_set_client(NULL); - popup_cycle(ft, FALSE); + event_cancel_all_key_grabs(); - return; + /* when nothing will be focused, send focus to the backup target */ + XSetInputFocus(ob_display, screen_support_win, RevertToPointerRoot, + event_curtime); } void focus_order_add_new(ObClient *c) { - guint d, i; - if (c->iconic) focus_order_to_top(c); else { - d = c->desktop; - if (d == DESKTOP_ALL) { - for (i = 0; i < screen_num_desktops; ++i) { - if (focus_order[i] && ((ObClient*)focus_order[i]->data)->iconic) - focus_order[i] = g_list_insert(focus_order[i], c, 0); - else - focus_order[i] = g_list_insert(focus_order[i], c, 1); - } - } else - if (focus_order[d] && ((ObClient*)focus_order[d]->data)->iconic) - focus_order[d] = g_list_insert(focus_order[d], c, 0); - else - focus_order[d] = g_list_insert(focus_order[d], c, 1); + g_assert(!g_list_find(focus_order, c)); + /* if there are any iconic windows, put this above them in the order, + but if there are not, then put it under the currently focused one */ + if (focus_order && ((ObClient*)focus_order->data)->iconic) + focus_order = g_list_insert(focus_order, c, 0); + else + focus_order = g_list_insert(focus_order, c, 1); } + + /* in the middle of cycling..? kill it. */ + focus_cycle_stop(c); } void focus_order_remove(ObClient *c) { - guint d, i; - - d = c->desktop; - if (d == DESKTOP_ALL) { - for (i = 0; i < screen_num_desktops; ++i) - focus_order[i] = g_list_remove(focus_order[i], c); - } else - focus_order[d] = g_list_remove(focus_order[d], c); + focus_order = g_list_remove(focus_order, c); + + /* in the middle of cycling..? kill it. */ + focus_cycle_stop(c); } -static void to_top(ObClient *c, guint d) +void focus_order_to_top(ObClient *c) { - focus_order[d] = g_list_remove(focus_order[d], c); + focus_order = g_list_remove(focus_order, c); if (!c->iconic) { - focus_order[d] = g_list_prepend(focus_order[d], c); + focus_order = g_list_prepend(focus_order, c); } else { GList *it; /* insert before first iconic window */ - for (it = focus_order[d]; - it && !((ObClient*)it->data)->iconic; it = it->next); - focus_order[d] = g_list_insert_before(focus_order[d], it, c); + for (it = focus_order; + it && !((ObClient*)it->data)->iconic; it = g_list_next(it)); + focus_order = g_list_insert_before(focus_order, it, c); } } -void focus_order_to_top(ObClient *c) -{ - guint d, i; - - d = c->desktop; - if (d == DESKTOP_ALL) { - for (i = 0; i < screen_num_desktops; ++i) - to_top(c, i); - } else - to_top(c, d); -} - -static void to_bottom(ObClient *c, guint d) +void focus_order_to_bottom(ObClient *c) { - focus_order[d] = g_list_remove(focus_order[d], c); + focus_order = g_list_remove(focus_order, c); if (c->iconic) { - focus_order[d] = g_list_append(focus_order[d], c); + focus_order = g_list_append(focus_order, c); } else { GList *it; /* insert before first iconic window */ - for (it = focus_order[d]; - it && !((ObClient*)it->data)->iconic; it = it->next); - g_list_insert_before(focus_order[d], it, c); + for (it = focus_order; + it && !((ObClient*)it->data)->iconic; it = g_list_next(it)); + focus_order = g_list_insert_before(focus_order, it, c); } } -void focus_order_to_bottom(ObClient *c) +ObClient *focus_order_find_first(guint desktop) +{ + GList *it; + for (it = focus_order; it; it = g_list_next(it)) { + ObClient *c = it->data; + if (c->desktop == desktop || c->desktop == DESKTOP_ALL) + return c; + } + return NULL; +} + +/*! Returns if a focus target has valid group siblings that can be cycled + to in its place */ +static gboolean focus_target_has_siblings(ObClient *ft, + gboolean iconic_windows, + gboolean all_desktops) + { - guint d, i; - - d = c->desktop; - if (d == DESKTOP_ALL) { - for (i = 0; i < screen_num_desktops; ++i) - to_bottom(c, i); - } else - to_bottom(c, d); + GSList *it; + + if (!ft->group) return FALSE; + + for (it = ft->group->members; it; it = g_slist_next(it)) { + ObClient *c = it->data; + /* check that it's not a helper window to avoid infinite recursion */ + if (c != ft && c->type == OB_CLIENT_TYPE_NORMAL && + focus_valid_target(c, TRUE, iconic_windows, all_desktops, + FALSE, FALSE)) + { + return TRUE; + } + } + return FALSE; +} + +gboolean focus_valid_target(ObClient *ft, + gboolean helper_windows, + gboolean iconic_windows, + gboolean all_desktops, + gboolean dock_windows, + gboolean desktop_windows) +{ + gboolean ok = FALSE; + + /* it's on this desktop unless you want all desktops. + + do this check first because it will usually filter out the most + windows */ + ok = (all_desktops || ft->desktop == screen_desktop || + ft->desktop == DESKTOP_ALL); + + /* the window can receive focus somehow */ + ok = ok && (ft->can_focus || ft->focus_notify); + + /* the window is not iconic, or we're allowed to go to iconic ones */ + ok = ok && (iconic_windows || !ft->iconic); + + /* it's the right type of window */ + if (dock_windows || desktop_windows) + ok = ok && ((dock_windows && ft->type == OB_CLIENT_TYPE_DOCK) || + (desktop_windows && ft->type == OB_CLIENT_TYPE_DESKTOP)); + /* modal windows are important and can always get focus if they are + visible and stuff, so don't change 'ok' based on their type */ + else if (!ft->modal) + /* normal non-helper windows are valid targets */ + ok = ok && + ((client_normal(ft) && !client_helper(ft)) + || + /* helper windows are valid targets if... */ + (client_helper(ft) && + /* ...a window in its group already has focus and we want to + include helper windows ... */ + ((focus_client && ft->group == focus_client->group && + helper_windows) || + /* ... or if there are no other windows in its group + that can be focused instead */ + !focus_target_has_siblings(ft, iconic_windows, all_desktops)))); + + /* it's not set to skip the taskbar (but this only applies to normal typed + windows, and is overridden if the window is modal) */ + ok = ok && (ft->type != OB_CLIENT_TYPE_NORMAL || + ft->modal || + !ft->skip_taskbar); + + /* it's not going to just send focus off somewhere else (modal window), + unless that modal window is not one of our valid targets, then let + you choose this window and bring the modal one here */ + { + ObClient *cft = client_focus_target(ft); + ok = ok && (ft == cft || !focus_valid_target(cft, + TRUE, + iconic_windows, + all_desktops, + dock_windows, + desktop_windows)); + } + + return ok; }