X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fclient.c;h=7b7872b37d7a0f8ea5b51093565f92ee6be18901;hb=00042637e8b8bef92456d96547230ec710cf6a7b;hp=59c2274e9104862dbdc19aaf9fc76b5d30fa0935;hpb=e7d225b84a2460b7483e56e102cbc35815c945c2;p=chaz%2Fopenbox diff --git a/openbox/client.c b/openbox/client.c index 59c2274e..7b7872b3 100644 --- a/openbox/client.c +++ b/openbox/client.c @@ -2,14 +2,14 @@ #include "screen.h" #include "prop.h" #include "extensions.h" -#include "config.h" #include "frame.h" -#include "engine.h" #include "event.h" #include "grab.h" #include "focus.h" #include "stacking.h" #include "dispatch.h" +#include "group.h" +#include "config.h" #include #include @@ -21,7 +21,7 @@ #define CLIENT_NOPROPAGATEMASK (ButtonPressMask | ButtonReleaseMask | \ ButtonMotionMask) -GSList *client_list = NULL; +GList *client_list = NULL; GHashTable *client_map = NULL; static Window *client_startup_stack_order = NULL; @@ -38,6 +38,7 @@ static void client_get_gravity(Client *self); static void client_showhide(Client *self); static void client_change_allowed_actions(Client *self); static void client_change_state(Client *self); +static void client_move_onscreen(Client *self); static Client *search_focus_tree(Client *node, Client *skip); static void client_apply_startup_state(Client *self); static Client *search_modal_tree(Client *node, Client *skip); @@ -65,8 +66,8 @@ void client_shutdown() void client_set_list() { Window *windows, *win_it; - GSList *it; - guint size = g_slist_length(client_list); + GList *it; + guint size = g_list_length(client_list); /* create an array of the window ids */ if (size > 0) { @@ -87,7 +88,6 @@ void client_set_list() void client_manage_all() { - ConfigValue focus_new; unsigned int i, j, nchild; Window w, *children; XWMHints *wmhints; @@ -132,28 +132,24 @@ void client_manage_all() w = client_startup_stack_order[i-1]; c = g_hash_table_lookup(client_map, &w); - g_message("0x%lx %d %d", c->window, c->iconic, c->shaded); if (c) stacking_lower(c); } g_free(client_startup_stack_order); client_startup_stack_order = NULL; client_startup_stack_size = 0; - if (!config_get("focusNew", Config_Bool, &focus_new)) - g_assert_not_reached(); - if (focus_new.bool) - focus_fallback(FALSE); + if (config_focus_new) + focus_fallback(Fallback_NoFocus); } void client_manage(Window window) { - Client *client; + Client *self; XEvent e; XWindowAttributes attrib; XSetWindowAttributes attrib_set; /* XWMHints *wmhint; */ guint i; - ConfigValue focus_new; grab_server(TRUE); @@ -186,6 +182,7 @@ void client_manage(Window window) XFree(wmhint); } */ + g_message("Managing window: %lx", window); /* choose the events we want to receive on the CLIENT window */ attrib_set.event_mask = CLIENT_EVENTMASK; @@ -196,59 +193,77 @@ void client_manage(Window window) /* create the Client struct, and populate it from the hints on the window */ - client = g_new(Client, 1); - client->window = window; - client_get_all(client); + self = g_new(Client, 1); + self->window = window; + client_get_all(self); /* remove the client's border (and adjust re gravity) */ - client_toggle_border(client, FALSE); + client_toggle_border(self, FALSE); /* specify that if we exit, the window should not be destroyed and should be reparented back to root automatically */ XChangeSaveSet(ob_display, window, SetModeInsert); /* create the decoration frame for the client window */ - client->frame = engine_frame_new(); + self->frame = frame_new(); - engine_frame_grab_client(client->frame, client); + frame_grab_client(self->frame, self); - client_apply_startup_state(client); + client_apply_startup_state(self); grab_server(FALSE); - client_list = g_slist_append(client_list, client); - stacking_list = g_list_append(stacking_list, client); - g_assert(!g_hash_table_lookup(client_map, &client->window)); - g_hash_table_insert(client_map, &client->window, client); + client_list = g_list_append(client_list, self); + stacking_list = g_list_append(stacking_list, self); + g_assert(!g_hash_table_lookup(client_map, &self->window)); + g_hash_table_insert(client_map, &self->window, self); /* update the focus lists */ - if (client->desktop == DESKTOP_ALL) { + if (self->desktop == DESKTOP_ALL) { for (i = 0; i < screen_num_desktops; ++i) - focus_order[i] = g_list_append(focus_order[i], client); + focus_order[i] = g_list_append(focus_order[i], self); } else { - i = client->desktop; - focus_order[i] = g_list_append(focus_order[i], client); + i = self->desktop; + focus_order[i] = g_list_append(focus_order[i], self); } - stacking_raise(client); + stacking_raise(self); screen_update_struts(); - dispatch_client(Event_Client_New, client, 0, 0); + dispatch_client(Event_Client_New, self, 0, 0); - client_showhide(client); - - dispatch_client(Event_Client_Mapped, client, 0, 0); + client_showhide(self); - if (!config_get("focusNew", Config_Bool, &focus_new)) - g_assert_not_reached(); - if (ob_state != State_Starting && focus_new.bool) - client_focus(client); + dispatch_client(Event_Client_Mapped, self, 0, 0); + + /* focus the new window? */ + if (ob_state != State_Starting) { + if (config_focus_new) + client_focus(self); + else if (self->transient_for) { + if (self->transient_for != TRAN_GROUP) {/* transient of a window */ + if (focus_client == self->transient_for) + client_focus(self); + } else { /* transient of a group */ + GSList *it; + + for (it = self->group->members; it; it = it->next) + if (focus_client == it->data) { + client_focus(self); + break; + } + } + } + } /* update the list hints */ client_set_list(); -/* g_message("Managed window 0x%lx", window);*/ + /* make sure the window is visible */ + client_move_onscreen(self); + + g_message("Managed window 0x%lx", window); } void client_unmanage_all() @@ -257,93 +272,136 @@ void client_unmanage_all() client_unmanage(client_list->data); } -void client_unmanage(Client *client) +void client_unmanage(Client *self) { guint i; int j; GSList *it; -/* g_message("Unmanaging window: %lx", client->window);*/ + g_message("Unmanaging window: %lx", self->window); - dispatch_client(Event_Client_Destroy, client, 0, 0); - g_assert(client != NULL); + dispatch_client(Event_Client_Destroy, self, 0, 0); + g_assert(self != NULL); /* remove the window from our save set */ - XChangeSaveSet(ob_display, client->window, SetModeDelete); + XChangeSaveSet(ob_display, self->window, SetModeDelete); /* we dont want events no more */ - XSelectInput(ob_display, client->window, NoEventMask); + XSelectInput(ob_display, self->window, NoEventMask); - engine_frame_hide(client->frame); + frame_hide(self->frame); - client_list = g_slist_remove(client_list, client); - stacking_list = g_list_remove(stacking_list, client); - g_hash_table_remove(client_map, &client->window); + client_list = g_list_remove(client_list, self); + stacking_list = g_list_remove(stacking_list, self); + g_hash_table_remove(client_map, &self->window); /* update the focus lists */ - if (client->desktop == DESKTOP_ALL) { + if (self->desktop == DESKTOP_ALL) { for (i = 0; i < screen_num_desktops; ++i) - focus_order[i] = g_list_remove(focus_order[i], client); + focus_order[i] = g_list_remove(focus_order[i], self); } else { - i = client->desktop; - focus_order[i] = g_list_remove(focus_order[i], client); + i = self->desktop; + focus_order[i] = g_list_remove(focus_order[i], self); } /* once the client is out of the list, update the struts to remove it's influence */ screen_update_struts(); - /* tell our parent that we're gone */ - if (client->transient_for != NULL) - client->transient_for->transients = - g_slist_remove(client->transient_for->transients, client); + /* tell our parent(s) that we're gone */ + if (self->transient_for == TRAN_GROUP) { /* transient of group */ + GSList *it; + + for (it = self->group->members; it; it = it->next) + if (it->data != self) + ((Client*)it->data)->transients = + g_slist_remove(((Client*)it->data)->transients, self); + } else if (self->transient_for) { /* transient of window */ + self->transient_for->transients = + g_slist_remove(self->transient_for->transients, self); + } /* tell our transients that we're gone */ - for (it = client->transients; it != NULL; it = it->next) { - ((Client*)it->data)->transient_for = NULL; - client_calc_layer(it->data); + for (it = self->transients; it != NULL; it = it->next) { + if (((Client*)it->data)->transient_for != TRAN_GROUP) { + ((Client*)it->data)->transient_for = NULL; + client_calc_layer(it->data); + } + } + + if (focus_client == self) + client_unfocus(self); + + /* remove from its group */ + if (self->group) { + group_remove(self->group, self); + self->group = NULL; } /* dispatch the unmapped event */ - dispatch_client(Event_Client_Unmapped, client, 0, 0); - g_assert(client != NULL); + dispatch_client(Event_Client_Unmapped, self, 0, 0); + g_assert(self != NULL); /* give the client its border back */ - client_toggle_border(client, TRUE); + client_toggle_border(self, TRUE); /* reparent the window out of the frame, and free the frame */ - engine_frame_release_client(client->frame, client); - client->frame = NULL; + frame_release_client(self->frame, self); + self->frame = NULL; if (ob_state != State_Exiting) { /* these values should not be persisted across a window unmapping/mapping */ - prop_erase(client->window, prop_atoms.net_wm_desktop); - prop_erase(client->window, prop_atoms.net_wm_state); + prop_erase(self->window, prop_atoms.net_wm_desktop); + prop_erase(self->window, prop_atoms.net_wm_state); } else { /* if we're left in an iconic state, the client wont be mapped. this is bad, since we will no longer be managing the window on restart */ - if (client->iconic) - XMapWindow(ob_display, client->window); + if (self->iconic) + XMapWindow(ob_display, self->window); } + g_message("Unmanaged window 0x%lx", self->window); + /* free all data allocated in the client struct */ - g_slist_free(client->transients); - for (j = 0; j < client->nicons; ++j) - g_free(client->icons[j].data); - if (client->nicons > 0) - g_free(client->icons); - g_free(client->title); - g_free(client->icon_title); - g_free(client->name); - g_free(client->class); - g_free(client->role); - g_free(client); + g_slist_free(self->transients); + for (j = 0; j < self->nicons; ++j) + g_free(self->icons[j].data); + if (self->nicons > 0) + g_free(self->icons); + g_free(self->title); + g_free(self->icon_title); + g_free(self->name); + g_free(self->class); + g_free(self->role); + g_free(self); /* update the list hints */ client_set_list(); } +static void client_move_onscreen(Client *self) +{ + Rect *a; + int x = self->frame->area.x, y = self->frame->area.y; + + a = screen_area(self->desktop); + if (x >= a->x + a->width - 1) + x = a->x + a->width - self->frame->area.width; + if (y >= a->y + a->height - 1) + y = a->y + a->height - self->frame->area.height; + if (x + self->frame->area.width - 1 < a->x) + x = a->x; + if (y + self->frame->area.height - 1< a->y) + y = a->y; + + frame_frame_gravity(self->frame, &x, &y); /* get where the client + should be */ + client_configure(self , Corner_TopLeft, x, y, + self->area.width, self->area.height, + TRUE, TRUE); +} + static void client_toggle_border(Client *self, gboolean show) { /* adjust our idea of where the client is, based on its border. When the @@ -428,7 +486,7 @@ static void client_get_all(Client *self) self->urgent = FALSE; self->positioned = FALSE; self->disabled_decorations = 0; - self->group = None; + self->group = NULL; self->nicons = 0; client_get_area(self); @@ -563,15 +621,14 @@ void client_update_transient_for(Client *self) c = g_hash_table_lookup(client_map, &t); g_assert(c != self);/* if this happens then we need to check for it*/ - if (!c /*XXX: && _group*/) { + if (!c && self->group) { /* not transient to a client, see if it is transient for a group */ - if (/*t == _group->leader() || */ + if (t == self->group->leader || t == None || t == ob_root) { /* window is a transient for its group! */ - /* XXX: for now this is treated as non-transient. - this needs to be fixed! */ + c = TRAN_GROUP; } } } else @@ -579,15 +636,33 @@ void client_update_transient_for(Client *self) /* if anything has changed... */ if (c != self->transient_for) { - if (self->transient_for) + if (self->transient_for == TRAN_GROUP) { /* transient of group */ + GSList *it; + + /* remove from old parents */ + for (it = self->group->members; it; it = it->next) + if (it->data != self) + ((Client*)it->data)->transients = + g_slist_remove(((Client*)it->data)->transients, self); + } else if (self->transient_for != NULL) { /* transient of window */ /* remove from old parent */ self->transient_for->transients = g_slist_remove(self->transient_for->transients, self); + } self->transient_for = c; - if (self->transient_for) + if (self->transient_for == TRAN_GROUP) { /* transient of group */ + GSList *it; + + /* add to new parents */ + for (it = self->group->members; it; it = it->next) + if (it->data != self) + ((Client*)it->data)->transients = + g_slist_append(((Client*)it->data)->transients, self); + } else if (self->transient_for != NULL) { /* transient of window */ /* add to new parent */ self->transient_for->transients = g_slist_append(self->transient_for->transients, self); + } } } @@ -706,7 +781,7 @@ void client_update_normal_hints(Client *self) /* get the hints from the window */ if (XGetWMNormalHints(ob_display, self->window, &size, &ret)) { - self->positioned = (size.flags & (PPosition|USPosition)); + self->positioned = !!(size.flags & (PPosition|USPosition)); if (size.flags & PWinGravity) { self->gravity = size.win_gravity; @@ -747,7 +822,8 @@ void client_setup_decor_and_functions(Client *self) { /* start with everything (cept fullscreen) */ self->decorations = Decor_Titlebar | Decor_Handle | Decor_Border | - Decor_Icon | Decor_AllDesktops | Decor_Iconify | Decor_Maximize; + Decor_Icon | Decor_AllDesktops | Decor_Iconify | Decor_Maximize | + Decor_Shade; self->functions = Func_Resize | Func_Move | Func_Iconify | Func_Maximize | Func_Shade; if (self->delete_window) { @@ -769,14 +845,14 @@ void client_setup_decor_and_functions(Client *self) break; case Type_Dialog: - /* dialogs cannot be maximized */ + case Type_Utility: + /* these windows cannot be maximized */ self->decorations &= ~Decor_Maximize; self->functions &= ~Func_Maximize; break; case Type_Menu: case Type_Toolbar: - case Type_Utility: /* these windows get less functionality */ self->decorations &= ~(Decor_Iconify | Decor_Handle); self->functions &= ~(Func_Iconify | Func_Resize); @@ -842,6 +918,8 @@ void client_setup_decor_and_functions(Client *self) self->decorations &= ~Decor_Maximize; if (self->disabled_decorations & Decor_AllDesktops) self->decorations &= ~Decor_AllDesktops; + if (self->disabled_decorations & Decor_Shade) + self->decorations &= ~Decor_Shade; if (self->disabled_decorations & Decor_Close) self->decorations &= ~Decor_Close; @@ -854,7 +932,7 @@ void client_setup_decor_and_functions(Client *self) if (self->frame) { /* change the decors on the frame, and with more/less decorations, we may also need to be repositioned */ - engine_frame_adjust_area(self->frame, TRUE, TRUE); + frame_adjust_area(self->frame, TRUE, TRUE); /* with new decor, the window's maximized size may change */ client_remaximize(self); } @@ -944,14 +1022,22 @@ void client_update_wmhints(Client *self) if (hints->flags & XUrgencyHint) ur = TRUE; - if (hints->flags & WindowGroupHint) { - if (hints->window_group != self->group) { - /* XXX: remove from the old group if there was one */ - self->group = hints->window_group; - /* XXX: do stuff with the group */ - } - } else /* no group! */ - self->group = None; + if (!(hints->flags & WindowGroupHint)) + hints->window_group = None; /* no group */ + /* did the group state change? */ + if (hints->window_group != (self->group ? self->group->leader : None)){ + /* remove from the old group if there was one */ + if (self->group != NULL) + group_remove(self->group, self); + if (hints->window_group != None) + self->group = group_add(hints->window_group, self); + + /* because the self->transient flag wont change from this call, + we don't need to update the window's type and such, only its + transient_for, and the transients lists of other windows in the + group may be affected */ + client_update_transient_for(self); + } if (hints->flags & IconPixmapHint) { client_update_kwm_icon(self); @@ -964,7 +1050,7 @@ void client_update_wmhints(Client *self) self->pixmap_icon_mask = None; if (self->frame) - engine_frame_adjust_icon(self->frame); + frame_adjust_icon(self->frame); } } @@ -1013,7 +1099,7 @@ void client_update_title(Client *self) self->title = data; if (self->frame) - engine_frame_adjust_title(self->frame); + frame_adjust_title(self->frame); } void client_update_icon_title(Client *self) @@ -1085,7 +1171,7 @@ void client_update_strut(Client *self) gulong *data; if (PROP_GET32A(self->window, net_wm_strut, cardinal, data, 4)) { - STRUT_SET(self->strut, data[0], data[1], data[2], data[3]); + STRUT_SET(self->strut, data[0], data[2], data[1], data[3]); g_free(data); } else STRUT_SET(self->strut, 0, 0, 0, 0); @@ -1137,7 +1223,7 @@ void client_update_icons(Client *self) } if (self->frame) - engine_frame_adjust_icon(self->frame); + frame_adjust_icon(self->frame); } void client_update_kwm_icon(Client *self) @@ -1152,7 +1238,7 @@ void client_update_kwm_icon(Client *self) self->pixmap_icon = self->pixmap_icon_mask = None; } if (self->frame) - engine_frame_adjust_icon(self->frame); + frame_adjust_icon(self->frame); } static void client_change_state(Client *self) @@ -1191,7 +1277,7 @@ static void client_change_state(Client *self) client_calc_layer(self); if (self->frame) - engine_frame_adjust_state(self->frame); + frame_adjust_state(self->frame); } static Client *search_focus_tree(Client *node, Client *skip) @@ -1217,7 +1303,7 @@ void client_calc_layer(Client *self) /* are we fullscreen, or do we have a fullscreen transient parent? */ c = self; fs = FALSE; - while (c) { + while (c && c != TRAN_GROUP) { /* XXX do smthng with the TRAN_GROUP case?*/ if (c->fullscreen) { fs = TRUE; break; @@ -1262,9 +1348,9 @@ static void client_showhide(Client *self) { if (client_should_show(self)) - engine_frame_show(self->frame); + frame_show(self->frame); else - engine_frame_hide(self->frame); + frame_hide(self->frame); } gboolean client_normal(Client *self) { @@ -1316,6 +1402,11 @@ void client_configure(Client *self, Corner anchor, int x, int y, int w, int h, { gboolean moved = FALSE, resized = FALSE; + /* gets the frame's position */ + frame_client_gravity(self->frame, &x, &y); + + /* these positions are frame positions, not client positions */ + /* set the size and position if fullscreen */ if (self->fullscreen) { x = 0; @@ -1326,17 +1417,18 @@ void client_configure(Client *self, Corner anchor, int x, int y, int w, int h, /* set the size and position if maximized */ if (self->max_horz) { x = screen_area(self->desktop)->x - self->frame->size.left; - w = screen_area(self->desktop)->x + - screen_area(self->desktop)->width; + w = screen_area(self->desktop)->width; } if (self->max_vert) { y = screen_area(self->desktop)->y; - h = screen_area(self->desktop)->y + - screen_area(self->desktop)->height - + h = screen_area(self->desktop)->height - self->frame->size.top - self->frame->size.bottom; } } + /* gets the client's position */ + frame_frame_gravity(self->frame, &x, &y); + /* these override the above states! if you cant move you can't move! */ if (user) { if (!(self->functions & Func_Move)) { @@ -1431,7 +1523,7 @@ void client_configure(Client *self, Corner anchor, int x, int y, int w, int h, /* move/resize the frame to match the request */ if (self->frame) { if (moved || resized) - engine_frame_adjust_area(self->frame, moved, resized); + frame_adjust_area(self->frame, moved, resized); if (!user || final) { XEvent event; @@ -1528,6 +1620,33 @@ void client_fullscreen(Client *self, gboolean fs, gboolean savearea) void client_iconify(Client *self, gboolean iconic, gboolean curdesk) { + /* move up the transient chain as far as possible first if deiconifying */ + if (!iconic) + while (self->transient_for) { + if (self->transient_for != TRAN_GROUP) { + if (self->transient_for->iconic == iconic) + break; + self = self->transient_for; + } else { + GSList *it; + + /* the check for TRAN_GROUP is to prevent an infinate loop with + 2 transients of the same group at the head of the group's + members list */ + for (it = self->group->members; it; it = it->next) { + Client *c = it->data; + + if (c != self && c->transient_for->iconic != iconic && + (c->transient_for != TRAN_GROUP || + c->group != self->group)) { + self = it->data; + break; + } + } + if (it == NULL) break; + } + } + if (self->iconic == iconic) return; /* nothing to do */ g_message("%sconifying window: 0x%lx", (iconic ? "I" : "Uni"), @@ -1543,7 +1662,7 @@ void client_iconify(Client *self, gboolean iconic, gboolean curdesk) XUnmapWindow(ob_display, self->window); } else { if (curdesk) - client_set_desktop(self, screen_desktop); + client_set_desktop(self, screen_desktop, FALSE); self->wmstate = self->shaded ? IconicState : NormalState; XMapWindow(ob_display, self->window); } @@ -1553,6 +1672,14 @@ void client_iconify(Client *self, gboolean iconic, gboolean curdesk) dispatch_client(iconic ? Event_Client_Unmapped : Event_Client_Mapped, self, 0, 0); + + /* iconify all transients */ + if (self->transients) { + GSList *it; + + for (it = self->transients; it != NULL; it = it->next) + if (it->data != self) client_iconify(it->data, iconic, curdesk); + } } void client_maximize(Client *self, gboolean max, int dir, gboolean savearea) @@ -1607,13 +1734,6 @@ void client_maximize(Client *self, gboolean max, int dir, gboolean savearea) PROP_SET32A(self->window, openbox_premax, cardinal, dimensions, 4); } - - /* pass the client's current position info. the client_configure - will move/size stuff as appropriate for a maximized window */ - x = self->area.x; - y = self->area.y; - w = self->area.width; - h = self->area.height; } else { long *dimensions; @@ -1660,7 +1780,7 @@ void client_maximize(Client *self, gboolean max, int dir, gboolean savearea) void client_shade(Client *self, gboolean shade) { - if (!(self->functions & Func_Shade) || /* can't */ + if ((!(self->functions & Func_Shade) && shade) || /* can't shade */ self->shaded == shade) return; /* already done */ /* when we're iconic, don't change the wmstate */ @@ -1669,7 +1789,7 @@ void client_shade(Client *self, gboolean shade) self->shaded = shade; client_change_state(self); /* resize the frame to just the titlebar */ - engine_frame_adjust_area(self->frame, FALSE, FALSE); + frame_adjust_area(self->frame, FALSE, FALSE); } void client_close(Client *self) @@ -1704,13 +1824,13 @@ void client_kill(Client *self) XKillClient(ob_display, self->window); } -void client_set_desktop(Client *self, guint target) +void client_set_desktop(Client *self, guint target, gboolean donthide) { guint old, i; if (target == self->desktop) return; - g_message("Setting desktop %u\n", target); + g_message("Setting desktop %u", target); g_assert(target < screen_num_desktops || target == DESKTOP_ALL); @@ -1718,21 +1838,33 @@ void client_set_desktop(Client *self, guint target) self->desktop = target; PROP_SET32(self->window, net_wm_desktop, cardinal, target); /* the frame can display the current desktop state */ - engine_frame_adjust_state(self->frame); + frame_adjust_state(self->frame); /* 'move' the window to the new desktop */ - client_showhide(self); + if (!donthide) + client_showhide(self); + /* raise if it was not already on the desktop */ + if (old != DESKTOP_ALL) + stacking_raise(self); screen_update_struts(); /* update the focus lists */ if (old == DESKTOP_ALL) { for (i = 0; i < screen_num_desktops; ++i) focus_order[i] = g_list_remove(focus_order[i], self); - focus_order[target] = g_list_prepend(focus_order[target], self); - } else { + } else focus_order[old] = g_list_remove(focus_order[old], self); - if (target == DESKTOP_ALL) - for (i = 0; i < screen_num_desktops; ++i) + if (target == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) { + if (config_focus_new) focus_order[i] = g_list_prepend(focus_order[i], self); + else + focus_order[i] = g_list_append(focus_order[i], self); + } + } else { + if (config_focus_new) + focus_order[target] = g_list_prepend(focus_order[target], self); + else + focus_order[target] = g_list_append(focus_order[target], self); } dispatch_client(Event_Client_Desktop, self, target, old); @@ -1910,20 +2042,32 @@ void client_set_state(Client *self, Atom action, long data1, long data2) client_change_state(self); /* change the hint to relect these changes */ } -gboolean client_focus(Client *self) +Client *client_focus_target(Client *self) { - XEvent ev; Client *child; /* if we have a modal child, then focus it, not us */ child = client_find_modal_child(self); - if (child) - return client_focus(child); + if (child) return child; + return self; +} +gboolean client_focusable(Client *self) +{ /* won't try focus if the client doesn't want it, or if the window isn't visible on the screen */ - if (!(self->frame->visible && - (self->can_focus || self->focus_notify))) + return self->frame->visible && + (self->can_focus || self->focus_notify); +} + +gboolean client_focus(Client *self) +{ + XEvent ev; + + /* choose the correct target */ + self = client_focus_target(self); + + if (!client_focusable(self)) return FALSE; /* do a check to see if the window has already been unmapped or destroyed @@ -1945,9 +2089,10 @@ gboolean client_focus(Client *self) } if (self->can_focus) - /* RevertToNone is used so that windows dont get focused inadvertantly - by having the pointer in them, and then FocusIn events go missing */ - XSetInputFocus(ob_display, self->window, RevertToNone, + /* RevertToPointerRoot causes much more headache than TevertToNone, so + I choose to use it always, hopefully to find errors quicker, if any + are left. (I hate X. I hate focus events.) */ + XSetInputFocus(ob_display, self->window, RevertToPointerRoot, event_lasttime); if (self->focus_notify) { @@ -1965,7 +2110,9 @@ gboolean client_focus(Client *self) XSendEvent(ob_display, self->window, FALSE, NoEventMask, &ce); } +#ifdef DEBUG_FOCUS g_message("focusing %lx", self->window); +#endif /* Cause the FocusIn to come back to us. Important for desktop switches, since otherwise we'll have no FocusIn on the queue and send it off to @@ -1977,7 +2124,10 @@ gboolean client_focus(Client *self) void client_unfocus(Client *self) { g_assert(focus_client == self); - focus_fallback(FALSE); +#ifndef DEBUG_FOCUS + g_message("client_unfocus"); +#endif + focus_fallback(Fallback_Unfocusing); } gboolean client_focused(Client *self)