X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fclient.c;h=790dba5a859cf7e69ad762d09f8bab7fd215cab1;hb=917c5c93490e97a2d6d6a74cb8cd562dd5066fcf;hp=4537f856f4345c3b0ad1aac8e440a4b623b4a40e;hpb=75b07a2bb3b98d581b39d3991cf1e9068452264a;p=chaz%2Fopenbox diff --git a/openbox/client.c b/openbox/client.c index 4537f856..790dba5a 100644 --- a/openbox/client.c +++ b/openbox/client.c @@ -5,6 +5,7 @@ #include "frame.h" #include "engine.h" #include "event.h" +#include "grab.h" #include "focus.h" #include "stacking.h" #include "dispatch.h" @@ -120,9 +121,8 @@ void client_manage(Window window) XWindowAttributes attrib; XSetWindowAttributes attrib_set; /* XWMHints *wmhint; */ - - XGrabServer(ob_display); - XSync(ob_display, FALSE); + + grab_server(TRUE); /* check if it has already been unmapped by the time we started mapping the grab does a sync so we don't have to here */ @@ -130,16 +130,14 @@ void client_manage(Window window) XCheckTypedWindowEvent(ob_display, window, UnmapNotify, &e)) { XPutBackEvent(ob_display, &e); - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); return; /* don't manage it */ } /* make sure it isn't an override-redirect window */ if (!XGetWindowAttributes(ob_display, window, &attrib) || attrib.override_redirect) { - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); return; /* don't manage it */ } @@ -148,8 +146,7 @@ void client_manage(Window window) if ((wmhint->flags & StateHint) && wmhint->initial_state == WithdrawnState) { /\* XXX: make dock apps work! *\/ - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); XFree(wmhint); return; } @@ -184,8 +181,7 @@ void client_manage(Window window) client_apply_startup_state(client); - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); client_list = g_slist_append(client_list, client); stacking_list = g_list_append(stacking_list, client); @@ -195,11 +191,11 @@ void client_manage(Window window) screen_update_struts(); - dispatch_client(Event_Client_New, client); + dispatch_client(Event_Client_New, client, 0, 0); client_showhide(client); - dispatch_client(Event_Client_Mapped, client); + dispatch_client(Event_Client_Mapped, client, 0, 0); /* grab all mouse bindings */ /*pointer_grab_all(client, TRUE);XXX*/ @@ -223,7 +219,7 @@ void client_unmanage(Client *client) g_message("Unmanaging window: %lx", client->window); - dispatch_client(Event_Client_Destroy, client); + dispatch_client(Event_Client_Destroy, client, 0, 0); /* remove the window from our save set */ XChangeSaveSet(ob_display, client->window, SetModeDelete); @@ -926,7 +922,7 @@ void client_update_wmhints(Client *self) /* fire the urgent callback if we're mapped, otherwise, wait until after we're mapped */ if (self->frame) - dispatch_client(Event_Client_Urgent, self); + dispatch_client(Event_Client_Urgent, self, self->urgent, 0); } } @@ -1220,8 +1216,6 @@ static void client_showhide(Client *self) engine_frame_show(self->frame); else engine_frame_hide(self->frame); - - dispatch_client(Event_Client_Visible, self); } gboolean client_normal(Client *self) { @@ -1246,7 +1240,7 @@ static void client_apply_startup_state(Client *self) client_shade(self, TRUE); } if (self->urgent) - dispatch_client(Event_Client_Urgent, self); + dispatch_client(Event_Client_Urgent, self, self->urgent, 0); if (self->max_vert && self->max_horz) { self->max_vert = self->max_horz = FALSE; @@ -1626,16 +1620,17 @@ void client_close(Client *self) XSendEvent(ob_display, self->window, FALSE, NoEventMask, &ce); } -void client_set_desktop(Client *self, unsigned int target) +void client_set_desktop(Client *self, guint target) { + guint old; + if (target == self->desktop) return; g_message("Setting desktop %u\n", target); - if (!(target < screen_num_desktops || - target == DESKTOP_ALL)) - return; + g_assert(target < screen_num_desktops || target == DESKTOP_ALL); + old = self->desktop; self->desktop = target; PROP_SET32(self->window, net_wm_desktop, cardinal, target); /* the frame can display the current desktop state */ @@ -1643,6 +1638,8 @@ void client_set_desktop(Client *self, unsigned int target) /* 'move' the window to the new desktop */ client_showhide(self); screen_update_struts(); + + dispatch_client(Event_Client_Desktop, self, target, old); } static Client *search_modal_tree(Client *node, Client *skip)