X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fclient.c;h=5d897f1c00faf01f78d3956f133ea98815b91b8a;hb=bf32b376b595eab16a300f63937cad1042361eec;hp=3ebfcd60f6ab47af7e189f95e2e7c29e7ef3a512;hpb=b48c0e0b47b649af5b93619af8021420264b19d6;p=chaz%2Fopenbox

diff --git a/openbox/client.c b/openbox/client.c
index 3ebfcd60..5d897f1c 100644
--- a/openbox/client.c
+++ b/openbox/client.c
@@ -2,6 +2,7 @@
 #include "screen.h"
 #include "prop.h"
 #include "extensions.h"
+#include "config.h"
 #include "frame.h"
 #include "engine.h"
 #include "event.h"
@@ -86,6 +87,7 @@ void client_set_list()
 
 void client_manage_all()
 {
+    ConfigValue focus_new;
     unsigned int i, j, nchild;
     Window w, *children;
     XWMHints *wmhints;
@@ -130,11 +132,17 @@ void client_manage_all()
 
         w = client_startup_stack_order[i-1];
         c = g_hash_table_lookup(client_map, &w);
+        g_message("0x%lx %d", c->window, c->iconic);
         if (c) stacking_lower(c);
     }
     g_free(client_startup_stack_order);
     client_startup_stack_order = NULL;
     client_startup_stack_size = 0;
+
+    if (!config_get("focusNew", Config_Bool, &focus_new))
+        g_assert_not_reached();
+    if (focus_new.bool)
+        focus_fallback(FALSE);
 }
 
 void client_manage(Window window)
@@ -145,6 +153,7 @@ void client_manage(Window window)
     XSetWindowAttributes attrib_set;
 /*    XWMHints *wmhint; */
     guint i;
+    ConfigValue focus_new;
 
     grab_server(TRUE);
 
@@ -231,6 +240,11 @@ void client_manage(Window window)
 
     dispatch_client(Event_Client_Mapped, client, 0, 0);
 
+    if (!config_get("focusNew", Config_Bool, &focus_new))
+        g_assert_not_reached();
+    if (ob_state != State_Starting && focus_new.bool)
+        client_focus(client);
+
     /* update the list hints */
     client_set_list();
 
@@ -1933,8 +1947,8 @@ gboolean client_focus(Client *self)
     }
 
     if (self->can_focus)
-	XSetInputFocus(ob_display, self->window, RevertToNone,
-                       CurrentTime);
+	XSetInputFocus(ob_display, self->window, RevertToPointerRoot,
+                       event_lasttime);
 
     if (self->focus_notify) {
 	XEvent ce;
@@ -1944,21 +1958,26 @@ gboolean client_focus(Client *self)
 	ce.xclient.window = self->window;
 	ce.xclient.format = 32;
 	ce.xclient.data.l[0] = prop_atoms.wm_take_focus;
-	ce.xclient.data.l[1] = CurrentTime;
+	ce.xclient.data.l[1] = event_lasttime;
 	ce.xclient.data.l[2] = 0l;
 	ce.xclient.data.l[3] = 0l;
 	ce.xclient.data.l[4] = 0l;
 	XSendEvent(ob_display, self->window, FALSE, NoEventMask, &ce);
     }
 
-    /* XSync(ob_display, FALSE); XXX Why sync? */
+    g_message("focusing %lx", self->window);
+
+    /* Cause the FocusIn to come back to us. Important for desktop switches,
+       since otherwise we'll have no FocusIn on the queue and send it off to
+       the focus_backup. */
+    XSync(ob_display, FALSE);
     return TRUE;
 }
 
 void client_unfocus(Client *self)
 {
     g_assert(focus_client == self);
-    client_set_focused(self, FALSE);
+    focus_fallback(FALSE);
 }
 
 gboolean client_focused(Client *self)
@@ -1966,22 +1985,6 @@ gboolean client_focused(Client *self)
     return self == focus_client;
 }
 
-void client_set_focused(Client *self, gboolean focused)
-{
-    if (focused) {
-        if (focus_client != self)
-            focus_set_client(self);
-    } else {
-	if (focus_client == self)
-	    focus_set_client(NULL);
-    }
-
-    /* focus state can affect the stacking layer */
-    client_calc_layer(self);
-
-    engine_frame_adjust_focus(self->frame);
-}
-
 Icon *client_icon(Client *self, int w, int h)
 {
     int i;