X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fclient.c;h=3e5430f02a86f0ad19e65bbfcae781eadf8817c5;hb=bcca5bb967f792e6dd9a1031e4bdcbef13be754d;hp=fdc171fb87a80cfa6d373ec36e4839c149371722;hpb=7f561a6a7acee71d55eecc9ed2bd278147ce2536;p=chaz%2Fopenbox diff --git a/openbox/client.c b/openbox/client.c index fdc171fb..3e5430f0 100644 --- a/openbox/client.c +++ b/openbox/client.c @@ -5,13 +5,12 @@ #include "frame.h" #include "engine.h" #include "event.h" +#include "grab.h" #include "focus.h" #include "stacking.h" -#include "pointer.h" -#include "hooks.h" -#include "openboxwrap.h" -#include "clientwrap.h" +#include "dispatch.h" +#include #include /*! The event mask to grab on client windows */ @@ -122,10 +121,9 @@ void client_manage(Window window) XWindowAttributes attrib; XSetWindowAttributes attrib_set; /* XWMHints *wmhint; */ - PyObject *cw; - - XGrabServer(ob_display); - XSync(ob_display, FALSE); + guint i; + + grab_server(TRUE); /* check if it has already been unmapped by the time we started mapping the grab does a sync so we don't have to here */ @@ -133,16 +131,14 @@ void client_manage(Window window) XCheckTypedWindowEvent(ob_display, window, UnmapNotify, &e)) { XPutBackEvent(ob_display, &e); - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); return; /* don't manage it */ } /* make sure it isn't an override-redirect window */ if (!XGetWindowAttributes(ob_display, window, &attrib) || attrib.override_redirect) { - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); return; /* don't manage it */ } @@ -151,8 +147,7 @@ void client_manage(Window window) if ((wmhint->flags & StateHint) && wmhint->initial_state == WithdrawnState) { /\* XXX: make dock apps work! *\/ - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); XFree(wmhint); return; } @@ -187,28 +182,30 @@ void client_manage(Window window) client_apply_startup_state(client); - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); client_list = g_slist_append(client_list, client); stacking_list = g_list_append(stacking_list, client); g_hash_table_insert(client_map, (gpointer)window, client); + /* update the focus lists */ + if (client->desktop == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_append(focus_order[i], client); + } else { + i = client->desktop; + focus_order[i] = g_list_append(focus_order[i], client); + } + stacking_raise(client); screen_update_struts(); - /* add to the python list */ - cw = clientwrap_new(client); - PyList_Append(openboxwrap_obj->client_list, cw); - Py_DECREF(cw); - - HOOKFIRECLIENT(managed, client); + dispatch_client(Event_Client_New, client, 0, 0); client_showhide(client); - /* grab all mouse bindings */ - pointer_grab_all(client, TRUE); + dispatch_client(Event_Client_Mapped, client, 0, 0); /* update the list hints */ client_set_list(); @@ -224,13 +221,13 @@ void client_unmanage_all() void client_unmanage(Client *client) { - int j, seq; - PyObject *cw; + guint i; + int j; GSList *it; g_message("Unmanaging window: %lx", client->window); - HOOKFIRECLIENT(closed, client); + dispatch_client(Event_Client_Destroy, client, 0, 0); /* remove the window from our save set */ XChangeSaveSet(ob_display, client->window, SetModeDelete); @@ -238,9 +235,6 @@ void client_unmanage(Client *client) /* we dont want events no more */ XSelectInput(ob_display, client->window, NoEventMask); - /* ungrab any mouse bindings */ - pointer_grab_all(client, FALSE); - engine_frame_hide(client->frame); /* give the client its border back */ @@ -253,23 +247,19 @@ void client_unmanage(Client *client) stacking_list = g_list_remove(stacking_list, client); g_hash_table_remove(client_map, (gpointer)client->window); + /* update the focus lists */ + if (client->desktop == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_remove(focus_order[i], client); + } else { + i = client->desktop; + focus_order[i] = g_list_remove(focus_order[i], client); + } + /* once the client is out of the list, update the struts to remove it's influence */ screen_update_struts(); - /* remove from the python list */ - cw = clientwrap_new(client); - seq = PySequence_Index(openboxwrap_obj->client_list, cw); - if (seq == -1) - PyErr_Clear(); - else - PySequence_DelItem(openboxwrap_obj->client_list, seq); - Py_DECREF(cw); - - /* notify the wrapper that its useless now */ - if (client->wrap != NULL) - client->wrap->client = NULL; - /* tell our parent that we're gone */ if (client->transient_for != NULL) client->transient_for->transients = @@ -281,7 +271,7 @@ void client_unmanage(Client *client) client_calc_layer(it->data); } - /* unfocus the client (calls the focus callbacks) (we're out of the + /* unfocus the client (dispatchs the focus event) (we're out of the transient lists already, so being modal doesn't matter) */ if (client->focused) client_unfocus(client); @@ -402,7 +392,6 @@ static void client_get_all(Client *self) self->disabled_decorations = 0; self->group = None; self->nicons = 0; - self->wrap = NULL; client_get_area(self); client_get_desktop(self); @@ -947,7 +936,7 @@ void client_update_wmhints(Client *self) /* fire the urgent callback if we're mapped, otherwise, wait until after we're mapped */ if (self->frame) - HOOKFIRECLIENT(urgent, self); + dispatch_client(Event_Client_Urgent, self, self->urgent, 0); } } @@ -1241,8 +1230,6 @@ static void client_showhide(Client *self) engine_frame_show(self->frame); else engine_frame_hide(self->frame); - - HOOKFIRECLIENT(visible, self); } gboolean client_normal(Client *self) { @@ -1267,7 +1254,7 @@ static void client_apply_startup_state(Client *self) client_shade(self, TRUE); } if (self->urgent) - HOOKFIRECLIENT(urgent, self); + dispatch_client(Event_Client_Urgent, self, self->urgent, 0); if (self->max_vert && self->max_horz) { self->max_vert = self->max_horz = FALSE; @@ -1647,16 +1634,17 @@ void client_close(Client *self) XSendEvent(ob_display, self->window, FALSE, NoEventMask, &ce); } -void client_set_desktop(Client *self, unsigned int target) +void client_set_desktop(Client *self, guint target) { + guint old, i; + if (target == self->desktop) return; g_message("Setting desktop %u\n", target); - if (!(target < screen_num_desktops || - target == DESKTOP_ALL)) - return; + g_assert(target < screen_num_desktops || target == DESKTOP_ALL); + old = self->desktop; self->desktop = target; PROP_SET32(self->window, net_wm_desktop, cardinal, target); /* the frame can display the current desktop state */ @@ -1664,6 +1652,22 @@ void client_set_desktop(Client *self, unsigned int target) /* 'move' the window to the new desktop */ client_showhide(self); screen_update_struts(); + + /* update the focus lists */ + if (old == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_remove(focus_order[i], self); + } else { + focus_order[old] = g_list_remove(focus_order[old], self); + } + if (target == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_prepend(focus_order[i], self); + } else { + focus_order[target] = g_list_prepend(focus_order[target], self); + } + + dispatch_client(Event_Client_Desktop, self, target, old); } static Client *search_modal_tree(Client *node, Client *skip)