X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fclient.c;h=3100993b2747c909e865b3147e84cd9d92adc502;hb=6321d28652409be598ece0f4889d25018b267ee6;hp=c8d33e833faa911e3cc9c04f8cb8aed4ed7e96ee;hpb=ad44e8a708b6836c9d84be7205457cfa82800a65;p=chaz%2Fopenbox diff --git a/openbox/client.c b/openbox/client.c index c8d33e83..3100993b 100644 --- a/openbox/client.c +++ b/openbox/client.c @@ -5,6 +5,7 @@ #include "frame.h" #include "engine.h" #include "event.h" +#include "grab.h" #include "focus.h" #include "stacking.h" #include "dispatch.h" @@ -120,9 +121,9 @@ void client_manage(Window window) XWindowAttributes attrib; XSetWindowAttributes attrib_set; /* XWMHints *wmhint; */ - - XGrabServer(ob_display); - XSync(ob_display, FALSE); + guint i; + + grab_server(TRUE); /* check if it has already been unmapped by the time we started mapping the grab does a sync so we don't have to here */ @@ -130,16 +131,14 @@ void client_manage(Window window) XCheckTypedWindowEvent(ob_display, window, UnmapNotify, &e)) { XPutBackEvent(ob_display, &e); - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); return; /* don't manage it */ } /* make sure it isn't an override-redirect window */ if (!XGetWindowAttributes(ob_display, window, &attrib) || attrib.override_redirect) { - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); return; /* don't manage it */ } @@ -148,8 +147,7 @@ void client_manage(Window window) if ((wmhint->flags & StateHint) && wmhint->initial_state == WithdrawnState) { /\* XXX: make dock apps work! *\/ - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); XFree(wmhint); return; } @@ -184,13 +182,21 @@ void client_manage(Window window) client_apply_startup_state(client); - XUngrabServer(ob_display); - XFlush(ob_display); + grab_server(FALSE); client_list = g_slist_append(client_list, client); stacking_list = g_list_append(stacking_list, client); g_hash_table_insert(client_map, (gpointer)window, client); + /* update the focus lists */ + if (client->desktop == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_append(focus_order[i], client); + } else { + i = client->desktop; + focus_order[i] = g_list_append(focus_order[i], client); + } + stacking_raise(client); screen_update_struts(); @@ -201,9 +207,6 @@ void client_manage(Window window) dispatch_client(Event_Client_Mapped, client, 0, 0); - /* grab all mouse bindings */ - /*pointer_grab_all(client, TRUE);XXX*/ - /* update the list hints */ client_set_list(); @@ -218,6 +221,7 @@ void client_unmanage_all() void client_unmanage(Client *client) { + guint i; int j; GSList *it; @@ -231,9 +235,6 @@ void client_unmanage(Client *client) /* we dont want events no more */ XSelectInput(ob_display, client->window, NoEventMask); - /* ungrab any mouse bindings */ - /*pointer_grab_all(client, FALSE);XXX*/ - engine_frame_hide(client->frame); /* give the client its border back */ @@ -246,6 +247,15 @@ void client_unmanage(Client *client) stacking_list = g_list_remove(stacking_list, client); g_hash_table_remove(client_map, (gpointer)client->window); + /* update the focus lists */ + if (client->desktop == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_remove(focus_order[i], client); + } else { + i = client->desktop; + focus_order[i] = g_list_remove(focus_order[i], client); + } + /* once the client is out of the list, update the struts to remove it's influence */ screen_update_struts(); @@ -261,7 +271,7 @@ void client_unmanage(Client *client) client_calc_layer(it->data); } - /* unfocus the client (calls the focus callbacks) (we're out of the + /* unfocus the client (dispatchs the focus event) (we're out of the transient lists already, so being modal doesn't matter) */ if (client->focused) client_unfocus(client); @@ -1455,7 +1465,7 @@ void client_iconify(Client *self, gboolean iconic, gboolean curdesk) { if (self->iconic == iconic) return; /* nothing to do */ - g_message("%sconifying window: 0x%lx\n", (iconic ? "I" : "Uni"), + g_message("%sconifying window: 0x%lx", (iconic ? "I" : "Uni"), self->window); self->iconic = iconic; @@ -1626,7 +1636,7 @@ void client_close(Client *self) void client_set_desktop(Client *self, guint target) { - guint old; + guint old, i; if (target == self->desktop) return; @@ -1643,6 +1653,20 @@ void client_set_desktop(Client *self, guint target) client_showhide(self); screen_update_struts(); + /* update the focus lists */ + if (old == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_remove(focus_order[i], self); + } else { + focus_order[old] = g_list_remove(focus_order[old], self); + } + if (target == DESKTOP_ALL) { + for (i = 0; i < screen_num_desktops; ++i) + focus_order[i] = g_list_prepend(focus_order[i], self); + } else { + focus_order[target] = g_list_prepend(focus_order[target], self); + } + dispatch_client(Event_Client_Desktop, self, target, old); }