X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Factions%2Fshowmenu.c;h=c1d53e41d8c76fbc74ac7d147cccdcfa69b50fd7;hb=a5005506a89ecffe13e04cbcda5c20a2fa6ba25d;hp=4b12548f6dd4bf9d070ec07a654c2e1d917d6f82;hpb=d642be361fde438e2b29b7374b4d6465f47ad9e9;p=chaz%2Fopenbox

diff --git a/openbox/actions/showmenu.c b/openbox/actions/showmenu.c
index 4b12548f..c1d53e41 100644
--- a/openbox/actions/showmenu.c
+++ b/openbox/actions/showmenu.c
@@ -10,12 +10,9 @@ static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node);
 static void     free_func(gpointer options);
 static gboolean run_func(ObActionsData *data, gpointer options);
 
-void action_showmenu_startup()
+void action_showmenu_startup(void)
 {
-    actions_register("ShowMenu",
-                     setup_func,
-                     free_func,
-                     run_func,
+    actions_register("ShowMenu", setup_func, free_func, run_func,
                      NULL, NULL);
 }
 
@@ -34,11 +31,8 @@ static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node)
 static void free_func(gpointer options)
 {
     Options *o = options;
-
-    if (o) {
-        g_free(o->name);
-        g_free(o);
-    }
+    g_free(o->name);
+    g_free(o);
 }
 
 /* Always return FALSE because its not interactive */
@@ -47,11 +41,8 @@ static gboolean run_func(ObActionsData *data, gpointer options)
     Options *o = options;
 
     /* you cannot call ShowMenu from inside a menu */
-    if (data->uact == OB_USER_ACTION_MENU_SELECTION) return FALSE;
-
-    if (o->name) {
+    if (data->uact != OB_USER_ACTION_MENU_SELECTION && o->name)
         menu_show(o->name, data->x, data->y, data->button != 0, data->client);
-    }
 
     return FALSE;
 }