X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Faction.c;h=e056487f681294dfc055a7e99a9ff7ef9b534765;hb=a7f65a818c48e272aa9c8c49f2339b46b794078e;hp=e16e177a1d01da9991732a980e7e373dca224060;hpb=0f544808b8372a6c8a2cbfae214f2803dd3c6170;p=chaz%2Fopenbox diff --git a/openbox/action.c b/openbox/action.c index e16e177a..e056487f 100644 --- a/openbox/action.c +++ b/openbox/action.c @@ -1,3 +1,22 @@ +/* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*- + + action.c for the Openbox window manager + Copyright (c) 2006 Mikael Magnusson + Copyright (c) 2003-2007 Dana Jansens + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + See the COPYING file for a copy of the GNU General Public License. +*/ + #include "debug.h" #include "client.h" #include "focus.h" @@ -10,28 +29,56 @@ #include "openbox.h" #include "grab.h" #include "keyboard.h" +#include "event.h" +#include "dock.h" +#include "config.h" +#include "mainloop.h" +#include "startupnotify.h" +#include "gettext.h" #include -typedef struct ActionString { - char *name; +inline void client_action_start(union ActionData *data) +{ + if (config_focus_follow) + if (data->any.context != OB_FRAME_CONTEXT_CLIENT && !data->any.button) + grab_pointer(TRUE, FALSE, OB_CURSOR_NONE); +} + +inline void client_action_end(union ActionData *data) +{ + if (config_focus_follow) + if (data->any.context != OB_FRAME_CONTEXT_CLIENT && !data->any.button) + grab_pointer(FALSE, FALSE, OB_CURSOR_NONE); +} + +typedef struct +{ + const gchar *name; void (*func)(union ActionData *); void (*setup)(ObAction **, ObUserAction uact); } ActionString; -static ObAction *action_new(void (*func)(union ActionData *data), - ObUserAction uact) +static ObAction *action_new(void (*func)(union ActionData *data)) { ObAction *a = g_new0(ObAction, 1); + a->ref = 1; a->func = func; return a; } -void action_free(ObAction *a) +void action_ref(ObAction *a) +{ + ++a->ref; +} + +void action_unref(ObAction *a) { if (a == NULL) return; + if (--a->ref > 0) return; + /* deal with pointers */ if (a->func == action_execute || a->func == action_restart) g_free(a->data.execute.path); @@ -41,61 +88,94 @@ void action_free(ObAction *a) g_free(a); } +ObAction* action_copy(const ObAction *src) +{ + ObAction *a = action_new(src->func); + + a->data = src->data; + + /* deal with pointers */ + if (a->func == action_execute || a->func == action_restart) + a->data.execute.path = g_strdup(a->data.execute.path); + else if (a->func == action_showmenu) + a->data.showmenu.name = g_strdup(a->data.showmenu.name); + + return a; +} + void setup_action_directional_focus_north(ObAction **a, ObUserAction uact) -{ +{ (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_NORTH; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_east(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_EAST; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_south(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_SOUTH; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_west(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_WEST; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_northeast(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_NORTHEAST; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_southeast(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_SOUTHEAST; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_southwest(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_SOUTHWEST; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_directional_focus_northwest(ObAction **a, ObUserAction uact) { (*a)->data.interdiraction.inter.any.interactive = TRUE; (*a)->data.interdiraction.direction = OB_DIRECTION_NORTHWEST; + (*a)->data.interdiraction.dialog = TRUE; + (*a)->data.interdiraction.dock_windows = FALSE; } void setup_action_send_to_desktop(ObAction **a, ObUserAction uact) { + (*a)->data.sendto.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendto.follow = TRUE; } void setup_action_send_to_desktop_prev(ObAction **a, ObUserAction uact) { + (*a)->data.sendtodir.inter.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendtodir.inter.any.interactive = TRUE; (*a)->data.sendtodir.dir = OB_DIRECTION_WEST; (*a)->data.sendtodir.linear = TRUE; @@ -105,6 +185,7 @@ void setup_action_send_to_desktop_prev(ObAction **a, ObUserAction uact) void setup_action_send_to_desktop_next(ObAction **a, ObUserAction uact) { + (*a)->data.sendtodir.inter.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendtodir.inter.any.interactive = TRUE; (*a)->data.sendtodir.dir = OB_DIRECTION_EAST; (*a)->data.sendtodir.linear = TRUE; @@ -114,6 +195,7 @@ void setup_action_send_to_desktop_next(ObAction **a, ObUserAction uact) void setup_action_send_to_desktop_left(ObAction **a, ObUserAction uact) { + (*a)->data.sendtodir.inter.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendtodir.inter.any.interactive = TRUE; (*a)->data.sendtodir.dir = OB_DIRECTION_WEST; (*a)->data.sendtodir.linear = FALSE; @@ -123,6 +205,7 @@ void setup_action_send_to_desktop_left(ObAction **a, ObUserAction uact) void setup_action_send_to_desktop_right(ObAction **a, ObUserAction uact) { + (*a)->data.sendtodir.inter.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendtodir.inter.any.interactive = TRUE; (*a)->data.sendtodir.dir = OB_DIRECTION_EAST; (*a)->data.sendtodir.linear = FALSE; @@ -132,6 +215,7 @@ void setup_action_send_to_desktop_right(ObAction **a, ObUserAction uact) void setup_action_send_to_desktop_up(ObAction **a, ObUserAction uact) { + (*a)->data.sendtodir.inter.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendtodir.inter.any.interactive = TRUE; (*a)->data.sendtodir.dir = OB_DIRECTION_NORTH; (*a)->data.sendtodir.linear = FALSE; @@ -141,6 +225,7 @@ void setup_action_send_to_desktop_up(ObAction **a, ObUserAction uact) void setup_action_send_to_desktop_down(ObAction **a, ObUserAction uact) { + (*a)->data.sendtodir.inter.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.sendtodir.inter.any.interactive = TRUE; (*a)->data.sendtodir.dir = OB_DIRECTION_SOUTH; (*a)->data.sendtodir.linear = FALSE; @@ -148,6 +233,11 @@ void setup_action_send_to_desktop_down(ObAction **a, ObUserAction uact) (*a)->data.sendtodir.follow = TRUE; } +void setup_action_desktop(ObAction **a, ObUserAction uact) +{ + (*a)->data.desktop.inter.any.interactive = FALSE; +} + void setup_action_desktop_prev(ObAction **a, ObUserAction uact) { (*a)->data.desktopdir.inter.any.interactive = TRUE; @@ -201,6 +291,9 @@ void setup_action_cycle_windows_next(ObAction **a, ObUserAction uact) (*a)->data.cycle.inter.any.interactive = TRUE; (*a)->data.cycle.linear = FALSE; (*a)->data.cycle.forward = TRUE; + (*a)->data.cycle.dialog = TRUE; + (*a)->data.cycle.dock_windows = FALSE; + (*a)->data.cycle.all_desktops = FALSE; } void setup_action_cycle_windows_previous(ObAction **a, ObUserAction uact) @@ -208,90 +301,151 @@ void setup_action_cycle_windows_previous(ObAction **a, ObUserAction uact) (*a)->data.cycle.inter.any.interactive = TRUE; (*a)->data.cycle.linear = FALSE; (*a)->data.cycle.forward = FALSE; + (*a)->data.cycle.dialog = TRUE; + (*a)->data.cycle.dock_windows = FALSE; + (*a)->data.cycle.all_desktops = FALSE; +} + +void setup_action_movefromedge_north(ObAction **a, ObUserAction uact) +{ + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; + (*a)->data.diraction.direction = OB_DIRECTION_NORTH; + (*a)->data.diraction.hang = TRUE; +} + +void setup_action_movefromedge_south(ObAction **a, ObUserAction uact) +{ + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; + (*a)->data.diraction.direction = OB_DIRECTION_SOUTH; + (*a)->data.diraction.hang = TRUE; +} + +void setup_action_movefromedge_east(ObAction **a, ObUserAction uact) +{ + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; + (*a)->data.diraction.direction = OB_DIRECTION_EAST; + (*a)->data.diraction.hang = TRUE; +} + +void setup_action_movefromedge_west(ObAction **a, ObUserAction uact) +{ + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; + (*a)->data.diraction.direction = OB_DIRECTION_WEST; + (*a)->data.diraction.hang = TRUE; } void setup_action_movetoedge_north(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_NORTH; + (*a)->data.diraction.hang = FALSE; } void setup_action_movetoedge_south(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_SOUTH; + (*a)->data.diraction.hang = FALSE; } void setup_action_movetoedge_east(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_EAST; + (*a)->data.diraction.hang = FALSE; } void setup_action_movetoedge_west(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_WEST; + (*a)->data.diraction.hang = FALSE; } void setup_action_growtoedge_north(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_NORTH; } void setup_action_growtoedge_south(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_SOUTH; } void setup_action_growtoedge_east(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_EAST; } void setup_action_growtoedge_west(ObAction **a, ObUserAction uact) { + (*a)->data.diraction.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.diraction.direction = OB_DIRECTION_WEST; } void setup_action_top_layer(ObAction **a, ObUserAction uact) { + (*a)->data.layer.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.layer.layer = 1; } void setup_action_normal_layer(ObAction **a, ObUserAction uact) { + (*a)->data.layer.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.layer.layer = 0; } void setup_action_bottom_layer(ObAction **a, ObUserAction uact) { + (*a)->data.layer.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.layer.layer = -1; } void setup_action_move(ObAction **a, ObUserAction uact) { + (*a)->data.moveresize.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.moveresize.move = TRUE; (*a)->data.moveresize.keyboard = - (uact == OB_USER_ACTION_KEYBOARD_KEY || + (uact == OB_USER_ACTION_NONE || + uact == OB_USER_ACTION_KEYBOARD_KEY || uact == OB_USER_ACTION_MENU_SELECTION); } void setup_action_resize(ObAction **a, ObUserAction uact) { + (*a)->data.moveresize.any.client_action = OB_CLIENT_ACTION_ALWAYS; (*a)->data.moveresize.move = FALSE; (*a)->data.moveresize.keyboard = - (uact == OB_USER_ACTION_KEYBOARD_KEY || + (uact == OB_USER_ACTION_NONE || + uact == OB_USER_ACTION_KEYBOARD_KEY || uact == OB_USER_ACTION_MENU_SELECTION); } void setup_action_showmenu(ObAction **a, ObUserAction uact) { + (*a)->data.showmenu.any.client_action = OB_CLIENT_ACTION_OPTIONAL; /* you cannot call ShowMenu from inside a menu, cuz the menu code makes assumptions that there is only one menu (and submenus) open at a time! */ if (uact == OB_USER_ACTION_MENU_SELECTION) { - action_free(*a); - a = NULL; + action_unref(*a); + *a = NULL; } } +void setup_action_focus(ObAction **a, ObUserAction uact) +{ + (*a)->data.any.client_action = OB_CLIENT_ACTION_OPTIONAL; +} + +void setup_client_action(ObAction **a, ObUserAction uact) +{ + (*a)->data.any.client_action = OB_CLIENT_ACTION_ALWAYS; +} + ActionString actionstrings[] = { { @@ -342,142 +496,167 @@ ActionString actionstrings[] = { "activate", action_activate, - NULL + setup_action_focus }, { "focus", action_focus, - NULL + setup_action_focus }, { "unfocus", action_unfocus, - NULL + setup_client_action }, { "iconify", action_iconify, - NULL + setup_client_action + }, + { + "focustobottom", + action_focus_order_to_bottom, + setup_client_action }, { "raiselower", action_raiselower, - NULL + setup_client_action }, { "raise", action_raise, - NULL + setup_client_action }, { "lower", action_lower, - NULL + setup_client_action }, { "close", action_close, - NULL + setup_client_action }, { "kill", action_kill, - NULL + setup_client_action }, { "shadelower", action_shadelower, - NULL + setup_client_action }, { "unshaderaise", action_unshaderaise, - NULL + setup_client_action }, { "shade", action_shade, - NULL + setup_client_action }, { "unshade", action_unshade, - NULL + setup_client_action }, { "toggleshade", action_toggle_shade, - NULL + setup_client_action }, { "toggleomnipresent", action_toggle_omnipresent, - NULL + setup_client_action }, { "moverelativehorz", action_move_relative_horz, - NULL + setup_client_action }, { "moverelativevert", action_move_relative_vert, - NULL + setup_client_action + }, + { + "movetocenter", + action_move_to_center, + setup_client_action }, { "resizerelativehorz", action_resize_relative_horz, - NULL + setup_client_action }, { "resizerelativevert", action_resize_relative_vert, - NULL + setup_client_action + }, + { + "moverelative", + action_move_relative, + setup_client_action + }, + { + "resizerelative", + action_resize_relative, + setup_client_action }, { "maximizefull", action_maximize_full, - NULL + setup_client_action }, { "unmaximizefull", action_unmaximize_full, - NULL + setup_client_action }, { "togglemaximizefull", action_toggle_maximize_full, - NULL + setup_client_action }, { "maximizehorz", action_maximize_horz, - NULL + setup_client_action }, { "unmaximizehorz", action_unmaximize_horz, - NULL + setup_client_action }, { "togglemaximizehorz", action_toggle_maximize_horz, - NULL + setup_client_action }, { "maximizevert", action_maximize_vert, - NULL + setup_client_action }, { "unmaximizevert", action_unmaximize_vert, - NULL + setup_client_action }, { "togglemaximizevert", action_toggle_maximize_vert, - NULL + setup_client_action + }, + { + "togglefullscreen", + action_toggle_fullscreen, + setup_client_action }, { "sendtodesktop", @@ -517,7 +696,7 @@ ActionString actionstrings[] = { "desktop", action_desktop, - NULL + setup_action_desktop }, { "desktopnext", @@ -552,7 +731,7 @@ ActionString actionstrings[] = { "toggledecorations", action_toggle_decorations, - NULL + setup_client_action }, { "move", @@ -564,6 +743,11 @@ ActionString actionstrings[] = action_moveresize, setup_action_resize }, + { + "toggledockautohide", + action_toggle_dockautohide, + NULL + }, { "toggleshowdesktop", action_toggle_show_desktop, @@ -639,6 +823,26 @@ ActionString actionstrings[] = action_cycle_windows, setup_action_cycle_windows_previous }, + { + "movefromedgenorth", + action_movetoedge, + setup_action_movefromedge_north + }, + { + "movefromedgesouth", + action_movetoedge, + setup_action_movefromedge_south + }, + { + "movefromedgewest", + action_movetoedge, + setup_action_movefromedge_west + }, + { + "movefromedgeeast", + action_movetoedge, + setup_action_movefromedge_east + }, { "movetoedgenorth", action_movetoedge, @@ -679,6 +883,11 @@ ActionString actionstrings[] = action_growtoedge, setup_action_growtoedge_east }, + { + "breakchroot", + action_break_chroot, + NULL + }, { NULL, NULL, @@ -686,35 +895,42 @@ ActionString actionstrings[] = } }; -ObAction *action_from_string(char *name, ObUserAction uact) +/* only key bindings can be interactive. thus saith the xor. + because of how the mouse is grabbed, mouse events dont even get + read during interactive events, so no dice! >:) */ +#define INTERACTIVE_LIMIT(a, uact) \ + if (uact != OB_USER_ACTION_KEYBOARD_KEY) \ + a->data.any.interactive = FALSE; + +ObAction *action_from_string(const gchar *name, ObUserAction uact) { ObAction *a = NULL; gboolean exist = FALSE; - int i; + gint i; for (i = 0; actionstrings[i].name; i++) if (!g_ascii_strcasecmp(name, actionstrings[i].name)) { exist = TRUE; - a = action_new(actionstrings[i].func, uact); + a = action_new(actionstrings[i].func); if (actionstrings[i].setup) actionstrings[i].setup(&a, uact); - /* only key bindings can be interactive. thus saith the xor. */ - if (uact != OB_USER_ACTION_KEYBOARD_KEY) - a->data.any.interactive = FALSE; + if (a) + INTERACTIVE_LIMIT(a, uact); break; } if (!exist) - g_warning("Invalid action '%s' requested. No such action exists.", + g_message(_("Invalid action '%s' requested. No such action exists."), name); if (!a) - g_warning("Invalid use of action '%s'. Action will be ignored.", name); + g_message(_("Invalid use of action '%s'. Action will be ignored."), + name); return a; } ObAction *action_parse(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node, ObUserAction uact) { - char *actname; + gchar *actname; ObAction *act = NULL; xmlNodePtr n; @@ -723,9 +939,18 @@ ObAction *action_parse(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node, if (act->func == action_execute || act->func == action_restart) { if ((n = parse_find_node("execute", node->xmlChildrenNode))) { gchar *s = parse_string(doc, n); - act->data.execute.path = ob_expand_tilde(s); + act->data.execute.path = parse_expand_tilde(s); g_free(s); } + if ((n = parse_find_node("startupnotify", node->xmlChildrenNode))) { + xmlNodePtr m; + if ((m = parse_find_node("enabled", n->xmlChildrenNode))) + act->data.execute.startupnotify = parse_bool(doc, m); + if ((m = parse_find_node("name", n->xmlChildrenNode))) + act->data.execute.name = parse_string(doc, m); + if ((m = parse_find_node("icon", n->xmlChildrenNode))) + act->data.execute.icon_name = parse_string(doc, m); + } } else if (act->func == action_showmenu) { if ((n = parse_find_node("menu", node->xmlChildrenNode))) act->data.showmenu.name = parse_string(doc, n); @@ -734,11 +959,28 @@ ObAction *action_parse(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node, act->func == action_resize_relative_horz || act->func == action_resize_relative_vert) { if ((n = parse_find_node("delta", node->xmlChildrenNode))) - act->data.relative.delta = parse_int(doc, n); + act->data.relative.deltax = parse_int(doc, n); + } else if (act->func == action_move_relative) { + if ((n = parse_find_node("x", node->xmlChildrenNode))) + act->data.relative.deltax = parse_int(doc, n); + if ((n = parse_find_node("y", node->xmlChildrenNode))) + act->data.relative.deltay = parse_int(doc, n); + } else if (act->func == action_resize_relative) { + if ((n = parse_find_node("left", node->xmlChildrenNode))) + act->data.relative.deltaxl = parse_int(doc, n); + if ((n = parse_find_node("up", node->xmlChildrenNode))) + act->data.relative.deltayu = parse_int(doc, n); + if ((n = parse_find_node("right", node->xmlChildrenNode))) + act->data.relative.deltax = parse_int(doc, n); + if ((n = parse_find_node("down", node->xmlChildrenNode))) + act->data.relative.deltay = parse_int(doc, n); } else if (act->func == action_desktop) { if ((n = parse_find_node("desktop", node->xmlChildrenNode))) act->data.desktop.desk = parse_int(doc, n); if (act->data.desktop.desk > 0) act->data.desktop.desk--; + if ((n = parse_find_node("dialog", node->xmlChildrenNode))) + act->data.desktop.inter.any.interactive = + parse_bool(doc, n); } else if (act->func == action_send_to_desktop) { if ((n = parse_find_node("desktop", node->xmlChildrenNode))) act->data.sendto.desk = parse_int(doc, n); @@ -748,87 +990,270 @@ ObAction *action_parse(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node, } else if (act->func == action_desktop_dir) { if ((n = parse_find_node("wrap", node->xmlChildrenNode))) act->data.desktopdir.wrap = parse_bool(doc, n); + if ((n = parse_find_node("dialog", node->xmlChildrenNode))) + act->data.desktopdir.inter.any.interactive = + parse_bool(doc, n); } else if (act->func == action_send_to_desktop_dir) { if ((n = parse_find_node("wrap", node->xmlChildrenNode))) act->data.sendtodir.wrap = parse_bool(doc, n); if ((n = parse_find_node("follow", node->xmlChildrenNode))) act->data.sendtodir.follow = parse_bool(doc, n); + if ((n = parse_find_node("dialog", node->xmlChildrenNode))) + act->data.sendtodir.inter.any.interactive = + parse_bool(doc, n); } else if (act->func == action_activate) { if ((n = parse_find_node("here", node->xmlChildrenNode))) act->data.activate.here = parse_bool(doc, n); } else if (act->func == action_cycle_windows) { if ((n = parse_find_node("linear", node->xmlChildrenNode))) act->data.cycle.linear = parse_bool(doc, n); + if ((n = parse_find_node("dialog", node->xmlChildrenNode))) + act->data.cycle.dialog = parse_bool(doc, n); + if ((n = parse_find_node("panels", node->xmlChildrenNode))) + act->data.cycle.dock_windows = parse_bool(doc, n); + if ((n = parse_find_node("allDesktops", + node->xmlChildrenNode))) + act->data.cycle.all_desktops = parse_bool(doc, n); + } else if (act->func == action_directional_focus) { + if ((n = parse_find_node("dialog", node->xmlChildrenNode))) + act->data.interdiraction.dialog = parse_bool(doc, n); + if ((n = parse_find_node("panels", node->xmlChildrenNode))) + act->data.interdiraction.dock_windows = parse_bool(doc, n); + } else if (act->func == action_raise || + act->func == action_lower || + act->func == action_raiselower || + act->func == action_shadelower || + act->func == action_unshaderaise) { } + INTERACTIVE_LIMIT(act, uact); } g_free(actname); } return act; } -void action_run_full(ObAction *a, struct _ObClient *c, - ObFrameContext context, - guint state, guint button, gint x, gint y, +void action_run_list(GSList *acts, ObClient *c, ObFrameContext context, + guint state, guint button, gint x, gint y, Time time, gboolean cancel, gboolean done) { + GSList *it; + ObAction *a; + gboolean inter = FALSE; + + if (!acts) + return; + if (x < 0 && y < 0) screen_pointer_pos(&x, &y); - a->data.any.c = c; - a->data.any.x = x; - a->data.any.y = y; + if (grab_on_keyboard()) + inter = TRUE; + else + for (it = acts; it; it = g_slist_next(it)) { + a = it->data; + if (a->data.any.interactive) { + inter = TRUE; + break; + } + } + + if (!inter) { + /* sometimes when we execute another app as an action, + it won't work right unless we XUngrabKeyboard first, + even though we grabbed the key/button Asychronously. + e.g. "gnome-panel-control --main-menu" */ + grab_keyboard(FALSE); + } + + for (it = acts; it; it = g_slist_next(it)) { + a = it->data; + + if (!(a->data.any.client_action == OB_CLIENT_ACTION_ALWAYS && !c)) { + a->data.any.c = a->data.any.client_action ? c : NULL; + a->data.any.context = context; + a->data.any.x = x; + a->data.any.y = y; - a->data.any.button = button; + a->data.any.button = button; - if (a->data.any.interactive) { - a->data.inter.cancel = cancel; - a->data.inter.final = done; - if (!(cancel || done)) - keyboard_interactive_grab(state, c, context, a); + a->data.any.time = time; + + if (a->data.any.interactive) { + a->data.inter.cancel = cancel; + a->data.inter.final = done; + if (!(cancel || done)) + if (!keyboard_interactive_grab(state, a->data.any.c, a)) + continue; + } + + /* XXX UGLY HACK race with motion event starting a move and the + button release gettnig processed first. answer: don't queue + moveresize starts. UGLY HACK XXX */ + if (a->data.any.interactive || a->func == action_moveresize) { + /* interactive actions are not queued */ + a->func(&a->data); + } else if ((context == OB_FRAME_CONTEXT_CLIENT || + (c && c->type == OB_CLIENT_TYPE_DESKTOP && + context == OB_FRAME_CONTEXT_DESKTOP)) && + (a->func == action_focus || + a->func == action_activate || + a->func == action_showmenu)) + { + /* XXX MORE UGLY HACK + actions from clicks on client windows are NOT queued. + this solves the mysterious click-and-drag-doesnt-work + problem. it was because the window gets focused and stuff + after the button event has already been passed through. i + dont really know why it should care but it does and it makes + a difference. + + however this very bogus ! ! + we want to send the button press to the window BEFORE + we do the action because the action might move the windows + (eg change desktops) and then the button press ends up on + the completely wrong window ! + so, this is just for that bug, and it will only NOT queue it + if it is a focusing action that can be used with the mouse + pointer. ugh. + + also with the menus, there is a race going on. if the + desktop wants to pop up a menu, and we do to, we send them + the button before we pop up the menu, so they pop up their + menu first. but not always. if we pop up our menu before + sending them the button press, then the result is + deterministic. yay. + */ + a->func(&a->data); + } else + ob_main_loop_queue_action(ob_main_loop, a); + } } +} + +void action_run_string(const gchar *name, struct _ObClient *c, Time time) +{ + ObAction *a; + GSList *l; - a->func(&a->data); + a = action_from_string(name, OB_USER_ACTION_NONE); + g_assert(a); + + l = g_slist_append(NULL, a); + + action_run(l, c, 0, time); } void action_execute(union ActionData *data) { GError *e = NULL; - char *cmd; + gchar *cmd, **argv = 0; if (data->execute.path) { cmd = g_filename_from_utf8(data->execute.path, -1, NULL, NULL, NULL); if (cmd) { - if (!g_spawn_command_line_async(cmd, &e)) { - g_warning("failed to execute '%s': %s", + if (!g_shell_parse_argv (cmd, NULL, &argv, &e)) { + g_message(_("Failed to execute '%s': %s"), cmd, e->message); + g_error_free(e); + } else if (data->execute.startupnotify) { + gchar *program; + + program = g_path_get_basename(argv[0]); + /* sets up the environment */ + sn_setup_spawn_environment(program, + data->execute.name, + data->execute.icon_name, + /* launch it on the current + desktop */ + screen_desktop, + data->execute.any.time); + if (!g_spawn_async(NULL, argv, NULL, G_SPAWN_SEARCH_PATH | + G_SPAWN_DO_NOT_REAP_CHILD, + NULL, NULL, NULL, &e)) { + g_message(_("Failed to execute '%s': %s"), + cmd, e->message); + g_error_free(e); + sn_spawn_cancel(); + } + unsetenv("DESKTOP_STARTUP_ID"); + g_free(program); + g_strfreev(argv); + } else { + if (!g_spawn_async(NULL, argv, NULL, G_SPAWN_SEARCH_PATH | + G_SPAWN_DO_NOT_REAP_CHILD, + NULL, NULL, NULL, &e)) + { + g_message(_("Failed to execute '%s': %s"), + cmd, e->message); + g_error_free(e); + } + g_strfreev(argv); } + g_free(cmd); } else { - g_warning("failed to convert '%s' from utf8", data->execute.path); + g_message(_("Failed to convert the path '%s' from utf8"), + data->execute.path); } } } void action_activate(union ActionData *data) { - if (data->activate.any.c) - client_activate(data->activate.any.c, data->activate.here); + if (data->client.any.c) { + /* similar to the openbox dock for dockapps, don't let user actions + give focus to 3rd-party docks (panels) either (unless they ask for + it themselves). */ + if (data->client.any.c->type != OB_CLIENT_TYPE_DOCK) { + /* if using focus_delay, stop the timer now so that focus doesn't + go moving on us */ + event_halt_focus_delay(); + + client_activate(data->activate.any.c, data->activate.here, TRUE); + } + } else { + /* focus action on something other than a client, make keybindings + work for this openbox instance, but don't focus any specific client + */ + focus_nothing(); + } } void action_focus(union ActionData *data) { - if (data->client.any.c) - client_focus(data->client.any.c); + if (data->client.any.c) { + /* similar to the openbox dock for dockapps, don't let user actions + give focus to 3rd-party docks (panels) either (unless they ask for + it themselves). */ + if (data->client.any.c->type != OB_CLIENT_TYPE_DOCK) { + /* if using focus_delay, stop the timer now so that focus doesn't + go moving on us */ + event_halt_focus_delay(); + + client_focus(data->client.any.c); + } + } else { + /* focus action on something other than a client, make keybindings + work for this openbox instance, but don't focus any specific client + */ + focus_nothing(); + } } void action_unfocus (union ActionData *data) { - if (data->client.any.c) - client_unfocus(data->client.any.c); + if (data->client.any.c == focus_client) + focus_fallback(FALSE); } void action_iconify(union ActionData *data) { - if (data->client.any.c) - client_iconify(data->client.any.c, TRUE, TRUE); + client_action_start(data); + client_iconify(data->client.any.c, TRUE, TRUE); + client_action_end(data); +} + +void action_focus_order_to_bottom(union ActionData *data) +{ + focus_order_to_bottom(data->client.any.c); } void action_raiselower(union ActionData *data) @@ -837,233 +1262,290 @@ void action_raiselower(union ActionData *data) GList *it; gboolean raise = FALSE; - if (!c) return; - for (it = stacking_list; it; it = g_list_next(it)) { - ObClient *cit = it->data; - - if (cit == c) break; - if (client_normal(cit) == client_normal(c) && - cit->layer == c->layer && - cit->frame->visible) - { - if (RECT_INTERSECTS_RECT(cit->frame->area, c->frame->area)) { - raise = TRUE; - break; + if (WINDOW_IS_CLIENT(it->data)) { + ObClient *cit = it->data; + + if (cit == c) break; + if (client_normal(cit) == client_normal(c) && + cit->layer == c->layer && + cit->frame->visible && + !client_search_transient(c, cit)) + { + if (RECT_INTERSECTS_RECT(cit->frame->area, c->frame->area)) { + raise = TRUE; + break; + } } } } if (raise) - stacking_raise(CLIENT_AS_WINDOW(c)); + action_raise(data); else - stacking_lower(CLIENT_AS_WINDOW(c)); + action_lower(data); } void action_raise(union ActionData *data) { - if (data->client.any.c) - stacking_raise(CLIENT_AS_WINDOW(data->client.any.c)); + client_action_start(data); + stacking_raise(CLIENT_AS_WINDOW(data->client.any.c)); + client_action_end(data); } void action_unshaderaise(union ActionData *data) { - if (data->client.any.c) { - if (data->client.any.c->shaded) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_shade(data->client.any.c, FALSE); - grab_pointer(FALSE, OB_CURSOR_NONE); - } else - stacking_raise(CLIENT_AS_WINDOW(data->client.any.c)); - } + if (data->client.any.c->shaded) + action_unshade(data); + else + action_raise(data); } void action_shadelower(union ActionData *data) { - if (data->client.any.c) { - if (data->client.any.c->shaded) - stacking_lower(CLIENT_AS_WINDOW(data->client.any.c)); - else { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_shade(data->client.any.c, TRUE); - grab_pointer(FALSE, OB_CURSOR_NONE); - } - } + if (data->client.any.c->shaded) + action_lower(data); + else + action_shade(data); } void action_lower(union ActionData *data) { - if (data->client.any.c) - stacking_lower(CLIENT_AS_WINDOW(data->client.any.c)); + client_action_start(data); + stacking_lower(CLIENT_AS_WINDOW(data->client.any.c)); + client_action_end(data); } void action_close(union ActionData *data) { - if (data->client.any.c) - client_close(data->client.any.c); + client_close(data->client.any.c); } void action_kill(union ActionData *data) { - if (data->client.any.c) - client_kill(data->client.any.c); + client_kill(data->client.any.c); } void action_shade(union ActionData *data) { - if (data->client.any.c) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_shade(data->client.any.c, TRUE); - grab_pointer(FALSE, OB_CURSOR_NONE); - } + client_action_start(data); + client_shade(data->client.any.c, TRUE); + client_action_end(data); } void action_unshade(union ActionData *data) { - if (data->client.any.c) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_shade(data->client.any.c, FALSE); - grab_pointer(FALSE, OB_CURSOR_NONE); - } + client_action_start(data); + client_shade(data->client.any.c, FALSE); + client_action_end(data); } void action_toggle_shade(union ActionData *data) { - if (data->client.any.c) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_shade(data->client.any.c, !data->client.any.c->shaded); - grab_pointer(FALSE, OB_CURSOR_NONE); - } + client_action_start(data); + client_shade(data->client.any.c, !data->client.any.c->shaded); + client_action_end(data); } void action_toggle_omnipresent(union ActionData *data) { - if (data->client.any.c) - client_set_desktop(data->client.any.c, - data->client.any.c->desktop == DESKTOP_ALL ? - screen_desktop : DESKTOP_ALL, FALSE); + client_set_desktop(data->client.any.c, + data->client.any.c->desktop == DESKTOP_ALL ? + screen_desktop : DESKTOP_ALL, FALSE); } void action_move_relative_horz(union ActionData *data) { ObClient *c = data->relative.any.c; - if (c) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_move(c, c->area.x + data->relative.delta, c->area.y); - grab_pointer(FALSE, OB_CURSOR_NONE); - } + client_action_start(data); + client_move(c, c->area.x + data->relative.deltax, c->area.y); + client_action_end(data); } void action_move_relative_vert(union ActionData *data) { ObClient *c = data->relative.any.c; - if (c) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_move(c, c->area.x, c->area.y + data->relative.delta); - grab_pointer(FALSE, OB_CURSOR_NONE); - } + client_action_start(data); + client_move(c, c->area.x, c->area.y + data->relative.deltax); + client_action_end(data); +} + +void action_move_to_center(union ActionData *data) +{ + ObClient *c = data->client.any.c; + Rect *area; + area = screen_area_monitor(c->desktop, 0); + client_action_start(data); + client_move(c, area->width / 2 - c->area.width / 2, + area->height / 2 - c->area.height / 2); + client_action_end(data); } void action_resize_relative_horz(union ActionData *data) { ObClient *c = data->relative.any.c; - if (c) { - grab_pointer(TRUE, OB_CURSOR_NONE); - client_resize(c, - c->area.width + data->relative.delta * c->size_inc.width, - c->area.height); - grab_pointer(FALSE, OB_CURSOR_NONE); - } + client_action_start(data); + client_resize(c, + c->area.width + data->relative.deltax * c->size_inc.width, + c->area.height); + client_action_end(data); } void action_resize_relative_vert(union ActionData *data) { ObClient *c = data->relative.any.c; - if (c && !c->shaded) { - grab_pointer(TRUE, OB_CURSOR_NONE); + if (!c->shaded) { + client_action_start(data); client_resize(c, c->area.width, c->area.height + - data->relative.delta * c->size_inc.height); - grab_pointer(FALSE, OB_CURSOR_NONE); + data->relative.deltax * c->size_inc.height); + client_action_end(data); } } +void action_move_relative(union ActionData *data) +{ + ObClient *c = data->relative.any.c; + client_action_start(data); + client_move(c, c->area.x + data->relative.deltax, c->area.y + + data->relative.deltay); + client_action_end(data); +} + +void action_resize_relative(union ActionData *data) +{ + ObClient *c = data->relative.any.c; + gint x, y, ow, w, oh, h, lw, lh; + + client_action_start(data); + + x = c->area.x; + y = c->area.y; + ow = c->area.width; + w = ow + data->relative.deltax * c->size_inc.width + + data->relative.deltaxl * c->size_inc.width; + oh = c->area.height; + h = oh + data->relative.deltay * c->size_inc.height + + data->relative.deltayu * c->size_inc.height; + + client_try_configure(c, &x, &y, &w, &h, &lw, &lh, TRUE); + client_move_resize(c, x + (ow - w), y + (oh - h), w, h); + client_action_end(data); +} + void action_maximize_full(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, TRUE, 0, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, TRUE, 0); + client_action_end(data); } void action_unmaximize_full(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, FALSE, 0, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, FALSE, 0); + client_action_end(data); } void action_toggle_maximize_full(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, - !(data->client.any.c->max_horz || - data->client.any.c->max_vert), - 0, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, + !(data->client.any.c->max_horz || + data->client.any.c->max_vert), + 0); + client_action_end(data); } void action_maximize_horz(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, TRUE, 1, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, TRUE, 1); + client_action_end(data); } void action_unmaximize_horz(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, FALSE, 1, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, FALSE, 1); + client_action_end(data); } void action_toggle_maximize_horz(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, - !data->client.any.c->max_horz, 1, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, + !data->client.any.c->max_horz, 1); + client_action_end(data); } void action_maximize_vert(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, TRUE, 2, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, TRUE, 2); + client_action_end(data); } void action_unmaximize_vert(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, FALSE, 2, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, FALSE, 2); + client_action_end(data); } void action_toggle_maximize_vert(union ActionData *data) { - if (data->client.any.c) - client_maximize(data->client.any.c, !data->client.any.c->max_vert, 2, TRUE); + client_action_start(data); + client_maximize(data->client.any.c, + !data->client.any.c->max_vert, 2); + client_action_end(data); +} + +void action_toggle_fullscreen(union ActionData *data) +{ + client_action_start(data); + client_fullscreen(data->client.any.c, !(data->client.any.c->fullscreen)); + client_action_end(data); } void action_send_to_desktop(union ActionData *data) { ObClient *c = data->sendto.any.c; - if (!c || !client_normal(c)) return; + if (!client_normal(c)) return; if (data->sendto.desk < screen_num_desktops || data->sendto.desk == DESKTOP_ALL) { client_set_desktop(c, data->sendto.desk, data->sendto.follow); if (data->sendto.follow) - screen_set_desktop(data->sendto.desk); + screen_set_desktop(data->sendto.desk, TRUE); } } void action_desktop(union ActionData *data) { - if (data->desktop.desk < screen_num_desktops || - data->desktop.desk == DESKTOP_ALL) - screen_set_desktop(data->desktop.desk); + static guint first = (unsigned) -1; + + if (data->inter.any.interactive && first == (unsigned) -1) + first = screen_desktop; + + if (!data->inter.any.interactive || + (!data->inter.cancel && !data->inter.final)) + { + if (data->desktop.desk < screen_num_desktops || + data->desktop.desk == DESKTOP_ALL) + { + screen_set_desktop(data->desktop.desk, TRUE); + if (data->inter.any.interactive) + screen_desktop_popup(data->desktop.desk, TRUE); + } + } else if (data->inter.cancel) { + screen_set_desktop(first, TRUE); + } + + if (!data->inter.any.interactive || data->inter.final) { + screen_desktop_popup(0, FALSE); + first = (unsigned) -1; + } } void action_desktop_dir(union ActionData *data) @@ -1072,11 +1554,16 @@ void action_desktop_dir(union ActionData *data) d = screen_cycle_desktop(data->desktopdir.dir, data->desktopdir.wrap, - data->sendtodir.linear, + data->desktopdir.linear, data->desktopdir.inter.any.interactive, data->desktopdir.inter.final, data->desktopdir.inter.cancel); - screen_set_desktop(d); + if (!data->sendtodir.inter.any.interactive || + !data->sendtodir.inter.final || + data->sendtodir.inter.cancel) + { + screen_set_desktop(d, TRUE); + } } void action_send_to_desktop_dir(union ActionData *data) @@ -1084,46 +1571,130 @@ void action_send_to_desktop_dir(union ActionData *data) ObClient *c = data->sendtodir.inter.any.c; guint d; - if (!c || !client_normal(c)) return; + if (!client_normal(c)) return; d = screen_cycle_desktop(data->sendtodir.dir, data->sendtodir.wrap, data->sendtodir.linear, data->sendtodir.inter.any.interactive, data->sendtodir.inter.final, data->sendtodir.inter.cancel); - client_set_desktop(c, d, data->sendtodir.follow); - if (data->sendtodir.follow) - screen_set_desktop(d); + if (!data->sendtodir.inter.any.interactive || + !data->sendtodir.inter.final || + data->sendtodir.inter.cancel) + { + client_set_desktop(c, d, data->sendtodir.follow); + if (data->sendtodir.follow) + screen_set_desktop(d, TRUE); + } } void action_desktop_last(union ActionData *data) { - screen_set_desktop(screen_last_desktop); + screen_set_desktop(screen_last_desktop, TRUE); } void action_toggle_decorations(union ActionData *data) { ObClient *c = data->client.any.c; - if (!c) return; - - c->decorate = !c->decorate; - client_setup_decor_and_functions(c); -} - -static guint32 pick_corner(int x, int y, int cx, int cy, int cw, int ch) -{ - if (x - cx > cw / 2) { - if (y - cy > ch / 2) - return prop_atoms.net_wm_moveresize_size_bottomright; - else - return prop_atoms.net_wm_moveresize_size_topright; - } else { - if (y - cy > ch / 2) - return prop_atoms.net_wm_moveresize_size_bottomleft; - else - return prop_atoms.net_wm_moveresize_size_topleft; - } + client_action_start(data); + client_set_undecorated(c, !c->undecorated); + client_action_end(data); +} + +static guint32 pick_corner(gint x, gint y, gint cx, gint cy, gint cw, gint ch) +{ + /* let's make x and y client relative instead of screen relative */ + x = x - cx; + y = ch - (y - cy); /* y is inverted, 0 is at the bottom of the window */ + +#define X x*ch/cw +#define A -4*X + 7*ch/3 +#define B 4*X -15*ch/9 +#define C -X/4 + 2*ch/3 +#define D X/4 + 5*ch/12 +#define E X/4 + ch/3 +#define F -X/4 + 7*ch/12 +#define G 4*X - 4*ch/3 +#define H -4*X + 8*ch/3 +#define a (y > 5*ch/9) +#define b (x < 4*cw/9) +#define c (x > 5*cw/9) +#define d (y < 4*ch/9) + + /* + Each of these defines (except X which is just there for fun), represents + the equation of a line. The lines they represent are shown in the diagram + below. Checking y against these lines, we are able to choose a region + of the window as shown. + + +---------------------A-------|-------|-------B---------------------+ + | |A B| | + | |A | | B| | + | | A B | | + | | A | | B | | + | | A B | | + | | A | | B | | + | northwest | A north B | northeast | + | | A | | B | | + | | A B | | + C---------------------+----A--+-------+--B----+---------------------D + |CCCCCCC | A B | DDDDDDD| + | CCCCCCCC | A | | B | DDDDDDDD | + | CCCCCCC A B DDDDDDD | + - - - - - - - - - - - +CCCCCCC+aaaaaaa+DDDDDDD+ - - - - - - - - - - - + | | b c | | + | west | b move c | east | + | | b c | | + - - - - - - - - - - - +EEEEEEE+ddddddd+FFFFFFF+- - - - - - - - - - - + | EEEEEEE G H FFFFFFF | + | EEEEEEEE | G | | H | FFFFFFFF | + |EEEEEEE | G H | FFFFFFF| + E---------------------+----G--+-------+--H----+---------------------F + | | G H | | + | | G | | H | | + | southwest | G south H | southeast | + | | G | | H | | + | | G H | | + | | G | | H | | + | | G H | | + | |G | | H| | + | |G H| | + +---------------------G-------|-------|-------H---------------------+ + */ + + if (y < A && y >= C) + return prop_atoms.net_wm_moveresize_size_topleft; + else if (y >= A && y >= B && a) + return prop_atoms.net_wm_moveresize_size_top; + else if (y < B && y >= D) + return prop_atoms.net_wm_moveresize_size_topright; + else if (y < C && y >= E && b) + return prop_atoms.net_wm_moveresize_size_left; + else if (y < D && y >= F && c) + return prop_atoms.net_wm_moveresize_size_right; + else if (y < E && y >= G) + return prop_atoms.net_wm_moveresize_size_bottomleft; + else if (y < G && y < H && d) + return prop_atoms.net_wm_moveresize_size_bottom; + else if (y >= H && y < F) + return prop_atoms.net_wm_moveresize_size_bottomright; + else + return prop_atoms.net_wm_moveresize_move; + +#undef X +#undef A +#undef B +#undef C +#undef D +#undef E +#undef F +#undef G +#undef H +#undef a +#undef b +#undef c +#undef d } void action_moveresize(union ActionData *data) @@ -1131,7 +1702,7 @@ void action_moveresize(union ActionData *data) ObClient *c = data->moveresize.any.c; guint32 corner; - if (!c || !client_normal(c)) return; + if (!client_normal(c)) return; if (data->moveresize.keyboard) { corner = (data->moveresize.move ? @@ -1150,6 +1721,26 @@ void action_moveresize(union ActionData *data) c->frame->size.right, c->area.height + c->frame->size.top + c->frame->size.bottom)); + const gchar *c; + if (corner == prop_atoms.net_wm_moveresize_size_topright) + c = "topright"; + else if (corner == prop_atoms.net_wm_moveresize_size_top) + c = "top"; + else if (corner == prop_atoms.net_wm_moveresize_size_topleft) + c = "topleft"; + else if (corner == prop_atoms.net_wm_moveresize_size_right) + c = "right"; + else if (corner == prop_atoms.net_wm_moveresize_move) + c = "middle"; + else if (corner == prop_atoms.net_wm_moveresize_size_left) + c = "left"; + else if (corner == prop_atoms.net_wm_moveresize_size_bottomright) + c = "bottomright"; + else if (corner == prop_atoms.net_wm_moveresize_size_bottom) + c = "bottom"; + else if (corner == prop_atoms.net_wm_moveresize_size_bottomleft) + c = "bottomleft"; + ob_debug("corner: %s\n", c); } moveresize_start(c, data->any.x, data->any.y, data->any.button, corner); @@ -1167,102 +1758,121 @@ void action_restart(union ActionData *data) void action_exit(union ActionData *data) { - ob_exit(); + ob_exit(0); } void action_showmenu(union ActionData *data) { if (data->showmenu.name) { menu_show(data->showmenu.name, data->any.x, data->any.y, - data->showmenu.any.c); + data->any.button, data->showmenu.any.c); } } void action_cycle_windows(union ActionData *data) { - focus_cycle(data->cycle.forward, data->cycle.linear, - data->cycle.inter.any.interactive, + /* if using focus_delay, stop the timer now so that focus doesn't go moving + on us */ + event_halt_focus_delay(); + + focus_cycle(data->cycle.forward, + data->cycle.all_desktops, + data->cycle.dock_windows, + data->cycle.linear, data->any.interactive, + data->cycle.dialog, data->cycle.inter.final, data->cycle.inter.cancel); } void action_directional_focus(union ActionData *data) { + /* if using focus_delay, stop the timer now so that focus doesn't go moving + on us */ + event_halt_focus_delay(); + focus_directional_cycle(data->interdiraction.direction, - data->interdiraction.inter.any.interactive, + data->interdiraction.dock_windows, + data->any.interactive, + data->interdiraction.dialog, data->interdiraction.inter.final, data->interdiraction.inter.cancel); } void action_movetoedge(union ActionData *data) { - int x, y; + gint x, y; ObClient *c = data->diraction.any.c; - if (!c) - return; x = c->frame->area.x; y = c->frame->area.y; switch(data->diraction.direction) { case OB_DIRECTION_NORTH: - y = client_directional_edge_search(c, OB_DIRECTION_NORTH); + y = client_directional_edge_search(c, OB_DIRECTION_NORTH, + data->diraction.hang) + - (data->diraction.hang ? c->frame->area.height : 0); break; case OB_DIRECTION_WEST: - x = client_directional_edge_search(c, OB_DIRECTION_WEST); + x = client_directional_edge_search(c, OB_DIRECTION_WEST, + data->diraction.hang) + - (data->diraction.hang ? c->frame->area.width : 0); break; case OB_DIRECTION_SOUTH: - y = client_directional_edge_search(c, OB_DIRECTION_SOUTH) - - c->frame->area.height; + y = client_directional_edge_search(c, OB_DIRECTION_SOUTH, + data->diraction.hang) + - (data->diraction.hang ? 0 : c->frame->area.height); break; case OB_DIRECTION_EAST: - x = client_directional_edge_search(c, OB_DIRECTION_EAST) - - c->frame->area.width; + x = client_directional_edge_search(c, OB_DIRECTION_EAST, + data->diraction.hang) + - (data->diraction.hang ? 0 : c->frame->area.width); break; default: g_assert_not_reached(); } - frame_frame_gravity(c->frame, &x, &y); - grab_pointer(TRUE, OB_CURSOR_NONE); + frame_frame_gravity(c->frame, &x, &y, c->area.width, c->area.height); + client_action_start(data); client_move(c, x, y); - grab_pointer(FALSE, OB_CURSOR_NONE); - + client_action_end(data); } void action_growtoedge(union ActionData *data) { - int x, y, width, height, dest; + gint x, y, width, height, dest; ObClient *c = data->diraction.any.c; - Rect *a = screen_area(c->desktop); + Rect *a; - if (!c) - return; - + a = screen_area(c->desktop); x = c->frame->area.x; y = c->frame->area.y; - width = c->frame->area.width; - height = c->frame->area.height; + /* get the unshaded frame's dimensions..if it is shaded */ + width = c->area.width + c->frame->size.left + c->frame->size.right; + height = c->area.height + c->frame->size.top + c->frame->size.bottom; switch(data->diraction.direction) { case OB_DIRECTION_NORTH: - dest = client_directional_edge_search(c, OB_DIRECTION_NORTH); + if (c->shaded) break; /* don't allow vertical resize if shaded */ + + dest = client_directional_edge_search(c, OB_DIRECTION_NORTH, FALSE); if (a->y == y) - height = c->frame->area.height / 2; + height = height / 2; else { - height = c->frame->area.y + c->frame->area.height - dest; + height = c->frame->area.y + height - dest; y = dest; } break; case OB_DIRECTION_WEST: - dest = client_directional_edge_search(c, OB_DIRECTION_WEST); + dest = client_directional_edge_search(c, OB_DIRECTION_WEST, FALSE); if (a->x == x) - width = c->frame->area.width / 2; + width = width / 2; else { - width = c->frame->area.x + c->frame->area.width - dest; + width = c->frame->area.x + width - dest; x = dest; } break; case OB_DIRECTION_SOUTH: - dest = client_directional_edge_search(c, OB_DIRECTION_SOUTH); + if (c->shaded) break; /* don't allow vertical resize if shaded */ + + dest = client_directional_edge_search(c, OB_DIRECTION_SOUTH, FALSE); if (a->y + a->height == y + c->frame->area.height) { height = c->frame->area.height / 2; y = a->y + a->height - height; @@ -1272,7 +1882,7 @@ void action_growtoedge(union ActionData *data) height -= (height - c->frame->area.height) % c->size_inc.height; break; case OB_DIRECTION_EAST: - dest = client_directional_edge_search(c, OB_DIRECTION_EAST); + dest = client_directional_edge_search(c, OB_DIRECTION_EAST, FALSE); if (a->x + a->width == x + c->frame->area.width) { width = c->frame->area.width / 2; x = a->x + a->width - width; @@ -1284,43 +1894,54 @@ void action_growtoedge(union ActionData *data) default: g_assert_not_reached(); } - frame_frame_gravity(c->frame, &x, &y); width -= c->frame->size.left + c->frame->size.right; height -= c->frame->size.top + c->frame->size.bottom; - grab_pointer(TRUE, OB_CURSOR_NONE); + frame_frame_gravity(c->frame, &x, &y, width, height); + client_action_start(data); client_move_resize(c, x, y, width, height); - grab_pointer(FALSE, OB_CURSOR_NONE); + client_action_end(data); } void action_send_to_layer(union ActionData *data) { - if (data->layer.any.c) - client_set_layer(data->layer.any.c, data->layer.layer); + client_set_layer(data->layer.any.c, data->layer.layer); } void action_toggle_layer(union ActionData *data) { ObClient *c = data->layer.any.c; - if (c) { - if (data->layer.layer < 0) - client_set_layer(c, c->below ? 0 : -1); - else if (data->layer.layer > 0) - client_set_layer(c, c->above ? 0 : 1); - } + client_action_start(data); + if (data->layer.layer < 0) + client_set_layer(c, c->below ? 0 : -1); + else if (data->layer.layer > 0) + client_set_layer(c, c->above ? 0 : 1); + client_action_end(data); +} + +void action_toggle_dockautohide(union ActionData *data) +{ + config_dock_hide = !config_dock_hide; + dock_configure(); } void action_toggle_show_desktop(union ActionData *data) { - screen_show_desktop(!screen_showing_desktop); + screen_show_desktop(!screen_showing_desktop, TRUE); } void action_show_desktop(union ActionData *data) { - screen_show_desktop(TRUE); + screen_show_desktop(TRUE, TRUE); } void action_unshow_desktop(union ActionData *data) { - screen_show_desktop(FALSE); + screen_show_desktop(FALSE, TRUE); +} + +void action_break_chroot(union ActionData *data) +{ + /* break out of one chroot */ + keyboard_reset_chains(1); }