X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=inc%2FMy%2FBuild.pm;h=add7449324a40ea0b641f6afe4252261433eb044;hb=8539173b3a410b7aca44069e3d5f07b43e2d2401;hp=33bfc2b05ae15ad8dc83fbb4324a485d2483ea58;hpb=23f5d71553692b5d53978eedeb8a7323a14ba988;p=chaz%2Fp5-Alien-ZMQ

diff --git a/inc/My/Build.pm b/inc/My/Build.pm
index 33bfc2b..add7449 100644
--- a/inc/My/Build.pm
+++ b/inc/My/Build.pm
@@ -1,6 +1,5 @@
 package My::Build;
 
-use v5.10;
 use warnings FATAL => 'all';
 use strict;
 use utf8;
@@ -10,7 +9,7 @@ use Cwd qw/realpath/;
 use Digest::SHA qw/sha1_hex/;
 use File::Path qw/remove_tree/;
 use File::Spec::Functions qw/catdir catfile/;
-use IPC::Cmd qw/can_run run/;
+use IPC::Run qw/run/;
 use LWP::Simple qw/getstore RC_OK/;
 use Module::Build;
 
@@ -30,20 +29,20 @@ sub ACTION_code {
     $self->have_c_compiler or die "C compiler not found";
 
     unless (exists $args{'zmq-skip-probe'}) {
-        say "Probing...";
+        print "Probing...\n";
         %vars = $self->probe_zeromq;
     }
 
-    if ($vars{inc_version} && $vars{lib_version}) {
-        say "Found ØMQ $vars{lib_version}; skipping installation";
+    if ($vars{inc_version} && $vars{lib_version} && $vars{inc_dir} && $vars{lib_dir}) {
+        print "Found ØMQ $vars{lib_version}; skipping installation\n";
     } else {
-        say "ØMQ not found; building from source...";
+        print "ØMQ not found; building from source...\n";
         %vars = $self->install_zeromq;
     }
 
     # write vars to ZMQ.pm
     my $module = catfile qw/blib lib Alien ZMQ.pm/;
-    open my $LIB, "<$module" or die "Cannot read module";
+    open my $LIB, '<', $module or die "Cannot read module";
     my $lib = do { local $/; <$LIB> };
     close $LIB;
     $lib =~ s/^sub inc_dir.*$/sub inc_dir { "$vars{inc_dir}" }/m;
@@ -52,12 +51,12 @@ sub ACTION_code {
     $lib =~ s/^sub lib_version.*$/sub lib_version { v$vars{lib_version} }/m;
     my @stats = stat $module;
     chmod 0644, $module;
-    open $LIB, ">$module" or die "Cannot write config to module";
+    open $LIB, '>', $module or die "Cannot write config to module";
     print $LIB $lib;
     close $LIB;
     chmod $stats[2], $module;
 
-    open my $TARGET, ">build-zeromq";
+    open my $TARGET, '>', "build-zeromq";
     print $TARGET time, "\n";
     close $TARGET;
 }
@@ -68,7 +67,7 @@ sub probe_zeromq {
     my %config = $cb->get_config;
 
     my $src = "test-$$.c";
-    open my $SRC, ">$src";
+    open my $SRC, '>', $src;
     print $SRC <<END;
 #include <stdio.h>
 #include <zmq.h>
@@ -102,9 +101,9 @@ END
 
         # use -I and -L flag arguments as extra search directories
         my $inc = `$pkg_config $pkg --cflags-only-I`;
-        push @inc_search, map { s/^-I//; $_ } split(/\s+/, $inc);
+        push @inc_search, map { s/^-I//; $_ } $cb->split_like_shell($inc);
         my $lib = `$pkg_config $pkg --libs-only-L`;
-        push @lib_search, map { s/^-L//; $_ } split(/\s+/, $lib);
+        push @lib_search, map { s/^-L//; $_ } $cb->split_like_shell($lib);
 
         last;
     }
@@ -153,26 +152,25 @@ END
 
 sub install_zeromq {
     my $self = shift;
-
-    can_run("libtool") or die "The libtool command cannot be found";
+    my $cb = $self->cbuilder;
 
     my $version = $self->notes('zmq-version');
     my $sha1 = $self->notes('zmq-sha1');
     my $archive = "zeromq-$version.tar.gz";
 
-    say "Downloading ØMQ $version source archive from download.zeromq.org...";
+    print "Downloading ØMQ $version source archive from download.zeromq.org...\n";
     getstore("http://download.zeromq.org/$archive", $archive) == RC_OK
         or die "Failed to download ØMQ source archive";
 
-    say "Verifying...";
+    print "Verifying...\n";
     my $sha1sum = Digest::SHA->new;
-    open my $ARCHIVE, "<$archive";
+    open my $ARCHIVE, '<', $archive or die "Can't open source archive";
     binmode $ARCHIVE;
     $sha1sum->addfile($ARCHIVE);
     close $ARCHIVE;
     $sha1sum->hexdigest eq $sha1 or die "Source archive checksum mismatch";
 
-    say "Extracting...";
+    print "Extracting...\n";
     Archive::Tar->new($archive)->extract;
     unlink $archive;
 
@@ -180,18 +178,23 @@ sub install_zeromq {
     my $basedir = $self->base_dir;
     my $datadir = catdir($basedir, "share");
     my $srcdir  = catdir($basedir, "zeromq-$version");
-
-    say "Configuring...";
-    my @config = split(/\s/, $self->args('zmq-config') || "");
     chdir $srcdir;
-    run(command => ["./configure", "--prefix=$prefix", @config])
+
+    print "Patching...\n";
+    for my $patch (glob("$basedir/files/zeromq-$version-*.patch")) {
+	run [qw/patch -p1/], '<', $patch or die "Failed to patch ØMQ";
+    }
+
+    print "Configuring...\n";
+    my @config = $cb->split_like_shell($self->args('zmq-config') || "");
+    $cb->do_system(qw/sh configure CPPFLAGS=-Wno-error/, "--prefix=$prefix", @config)
         or die "Failed to configure ØMQ";
 
-    say "Compiling...";
-    run(command => ['make']) or die "Failed to make ØMQ";
+    print "Compiling...\n";
+    $cb->do_system("make") or die "Failed to make ØMQ";
 
-    say "Installing...";
-    run(command => [qw|make install prefix=/|, "DESTDIR=$datadir"])
+    print "Installing...\n";
+    $cb->do_system(qw|make install prefix=/|, "DESTDIR=$datadir")
         or die "Failed to install ØMQ";
 
     chdir $basedir;